User Story

As a developer, i need to have reliable helper functions for crafting Windows boot scripts so that those Machines will join the cluster without issue. Having idempotent functions that properly add or remove the necessary tags will allow me to do that.

Background

The Windows helper functions added in this PR (https://github.com/openshift/machine-api-operator/pull/1030) made the assumptions that the script would be strictly wrapped in the `powershell` tags. when looking at the source code (https://github.com/openshift/windows-machine-config-operator/blob/master/pkg/secrets/secrets.go#L54-L77) it appears that there is an extra set of tags on the script data.

As this format is released in the current WMCO, all the information should be taken into account by the helper functions. This will allow the AWS and Azure clients to continue functioning as we transition to not using the tags in the script data.

Steps

• update helper functions to detect persist tags
• update unit tests to accommodate the changes

Stakeholders

• cloud team
• winc team

Definition of Done

• Script helper functions properly detect and remove, or add, the necessary tags as defined in the WMCO code

• Docs

• n/a

• Testing

• Unit testing in MAO