User Story

As a user I have created a machine with the wrong ProviderSpec, I would like to fix or remove it but cannot because of the validating webhooks. If the webhooks allowed removing the finalizer, even when the provider spec is incorrect, then i could remove these machines.

Background

This is related to OCPCLOUD-1411, we have seen a scenario where a user created an AWS provider spec in a vSphere cluster. In this case the user could not remove the finalizer because the provider spec was incorrect, and for the wrong infrastructure.

Steps

• Webhooks should allow removing the finalizer for machines in a failed state

Stakeholders

• cloud team

Definition of Done

• Finalizers can be removed for machines in failed state, regardless of provider spec errors

• Docs

• We should review and update the troubleshooting guide and faq

• Testing

• unit tests should be added to exercise this behavior