Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-948

OLM sets invalid SCC label on its namespaces

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • 4.12
    • OLM
    • Moderate
    • None
    • X-Files 232
    • 1
    • Rejected
    • False
    • Hide

      None

       

      Show
      None  
    • Blank out the unused "openshift.io/scc" label. The label has no effect, and this value is less confusing than "anyuid" which might be misinterpreted.

      Description of problem:

      OLM is setting the "openshift.io/scc" label to "anyuid" on several namespaces:
      
      https://github.com/openshift/operator-framework-olm/blob/d817e09c2565b825afd8bfc9bb546eeff28e47e7/manifests/0000_50_olm_00-namespace.yaml#L23
      https://github.com/openshift/operator-framework-olm/blob/d817e09c2565b825afd8bfc9bb546eeff28e47e7/manifests/0000_50_olm_00-namespace.yaml#L8
      
      this label has no effect and will lead to confusion.  It should be set to emptystring for now (removing it entirely will have no effect on upgraded clusters because the CVO does not remove deleted labels, so the next best thing is to clear the value).
      
      For bonus points, OLM should remove the label entirely from the manifest and add migration logic to remove the existing label from these namespaces to handle upgraded clusters that already have it.
      
      

      Version-Release number of selected component (if applicable):

      Not sure how long this has been an issue, but fixing it in 4.12+ should be sufficient.
      
      

      How reproducible:

      always
      
      

      Steps to Reproduce:

      1. install cluster
      2. examine namespace labels
      
      

      Actual results:

      label is present
      
      

      Expected results:

      
      

      ideally label should not be present, but in the short term setting it to emptystring is the quick fix and is better than nothing.

            tshort@redhat.com Todd Short
            bparees@redhat.com Ben Parees
            Kui Wang Kui Wang
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: