Originally reported by Emilien on https://issues.redhat.com/browse/OSASINFRA-2788

—

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_csi-driver-manila-operator/138/pull-ci-openshift-csi-driver-manila-operator-master-e2e-openstack-csi/1493626641782411264/artifacts/e2e-openstack-csi/gather-extra/artifacts/pods/openshift-manila-csi-driver_openstack-manila-csi-controllerplugin-5fd6d4bcdf-rqfwl_csi-snapshotter.log
 
The error comes from CreateSnapshot call validation, https://github.com/kubernetes/cloud-provider-openstack/blob/f1704c89ae2ca0da43969887f80d0913f2f738cd/pkg/csi/manila/util.go#L206
I.e. the volume snapshot class used by the test does not have `csi.storage.k8s.io/snapshotter-secret-name` and `csi.storage.k8s.io/snapshotter-secret-namespace` parameters.
https://kubernetes-csi.github.io/docs/secrets-and-credentials-volume-snapshot-class.html
 
I think there are two issues with it, both should be fixed in the operator (I don't have OCP cluster with Manila):
1. The operator must file the secrets in the default volume snapshot class. Right now, there are not such parameters: https://github.com/openshift/csi-driver-manila-operator/blob/master/assets/volumesnapshotclass.yaml
2. The CSI test manifests must declare that VolumeSnapshotClasses created in the tests should be copied from from the default one, i.e. use SnapshotClass.FromExistingClassName: <the default volume snapshot class>
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/external/external.go

See also https://kubernetes-csi.github.io/docs/secrets-and-credentials-volume-snapshot-class.html