Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-76919

Missing x-kubernetes-list-type tag on kubelet machine config's status.conditions field

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • 4.21.z
    • Node / Kubelet
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • All
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      The kubelet machine config's status.conditions field hasn't got the tag x-kubernetes-list-type in the CRD and this is causing the CI verify-crd-schema check to fail on each PR that is regenerating one of the CR including this field with the following error:

          ----- SCHEMACHECK -----
      ERROR: ListsMustHaveSSATags: crd/kubeletconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type
      ----- machineconfiguration.openshift.io ----- v1 ----- machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-Default.crd.yaml -----
      ----- SCHEMACHECK -----
      ERROR: ListsMustHaveSSATags: crd/kubeletconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type
      ----- machineconfiguration.openshift.io ----- v1 ----- machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-DevPreviewNoUpgrade.crd.yaml -----
      ----- SCHEMACHECK -----
      ERROR: ListsMustHaveSSATags: crd/kubeletconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type
      ----- machineconfiguration.openshift.io ----- v1 ----- machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-OKD.crd.yaml -----
      ----- SCHEMACHECK -----
      ERROR: ListsMustHaveSSATags: crd/kubeletconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type
      ----- machineconfiguration.openshift.io ----- v1 ----- machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-TechPreviewNoUpgrade.crd.yaml -----
      ----- SCHEMACHECK -----
      ERROR: ListsMustHaveSSATags: crd/kubeletconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type
      F0213 15:54:49.899418   11080 root.go:64] Error running codegen: 
      error running generator schemacheck on group machineconfiguration.openshift.io: 
                    
      	could not run schemacheck generator for group/version machineconfiguration.openshift.io/v1: 
      		ListsMustHaveSSATags: 
      			crd/kubeletconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type
      6 skipped lines...
      		ListsMustHaveSSATags: 
                    
      			crd/kubeletconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type

      Version-Release number of selected component (if applicable):

          4.22

      How reproducible:

      Change a field that it is included in one of the affected kubelet machine config CRD and update the CRD    

      Steps to Reproduce:

          1. Change a field included into kubelet machine config 
          2. Perform a make update-codegen-crds     
          3. Perform a make verify-crd-schema or open a new PR   

      Actual results:

          The make verify-crd-schema is failing
          See https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2583/pull-ci-openshift-api-master-verify-crd-schema/2022337244311851008#1:build-log.txt%3A1273

           

      Expected results:

          The make verify-crd-schema should be executed successfully

      Additional info:

          

              kehannon Kevin Hannon
              dsalerno@redhat.com Davide Salerno
              None
              None
              Min Li Min Li
              None
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: