-
Bug
-
Resolution: Unresolved
-
Normal
-
None
-
4.18.z
-
None
-
False
-
-
None
-
Moderate
-
Yes
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
Description of problem:
Openshift installer on azure remove existing resource group tags
Version-Release number of selected component (if applicable):
4.18 (CAPI installer)
How reproducible:
Always
Steps to Reproduce:
1. Create resource groups with tags (used to set landing zone)
2. Install Openshift 4.18
Actual results:
Existing tags removed
Expected results:
Existing tags not removed No double tagging (see additional info
Additional info:
- This appears starting 4.18 since CAPI is now the default in the installer. Tagging happens twice today for azure: The original tagging in https://github.com/openshift/installer/blob/release-4.18/pkg/asset/cluster/azure/azure.go#L124 that correctly retrieves existing tags The CAPI retagging in https://github.com/openshift/installer/blob/release-4.18/pkg/infrastructure/azure/azure.go#L105 this time it does not retrieve the existing tags (Ultimately it tags twice. - Furthermore if you look even at the original code comment https://github.com/openshift/installer/blob/release-4.18/pkg/infrastructure/azure/azure.go#L105 it says "The cluster resource group when created by the installer is tagged with " so this is not true here it tags the resourcegroup that we provide as parameter that already exist. - Workaround; inject tags into installer config