Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-74630

ABI failures after cluster is registered are ignored

XMLWordPrintable

    • None
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • In Progress
    • Bug Fix
    • Hide
      Before this update, when installing a cluster with the Agent-based Installer and configuring `installConfig` overrides such as enabling FIPS mode, a failure to apply these overrides would not cause the application of other overrides to be retried. As a result, any error in the overrides caused all other overrides to be ignored. With this release, this application of overrides is checked for completion, so that either all of the overrides are applied successfully or the installation does not proceed. (link:https://issues.redhat.com/browse/OCPBUGS-74630[OCPBUGS-74630])
      Show
      Before this update, when installing a cluster with the Agent-based Installer and configuring `installConfig` overrides such as enabling FIPS mode, a failure to apply these overrides would not cause the application of other overrides to be retried. As a result, any error in the overrides caused all other overrides to be ignored. With this release, this application of overrides is checked for completion, so that either all of the overrides are applied successfully or the installation does not proceed. (link: https://issues.redhat.com/browse/OCPBUGS-74630 [ OCPBUGS-74630 ])
    • None
    • None
    • None
    • None

      This is a clone of issue OCPBUGS-65901. The following is the description of the original issue:
      —
      This is a clone of issue OCPBUGS-56913. The following is the description of the original issue:
      —
      This issue was found when debugging https://issues.redhat.com/browse/OCPBUGS-56596. When the cluster is registered with assisted-service in the agent-register-cluster.service, the first thing it does is register the cluster https://github.com/openshift/assisted-service/blob/master/cmd/agentbasedinstaller/register.go#L111 and then it sets any installConfig Overrides here https://github.com/openshift/assisted-service/blob/master/cmd/agentbasedinstaller/register.go#L123-L147.

      If there is a failure in setting the installConfig overrides the service will terminate with a failure and then be restarted. The problem is, since the cluster HAS been registered, when it restarts it checks for the cluster, finds it, and skips the registration here
      https://github.com/openshift/assisted-service/blob/master/cmd/agentbasedinstaller/client/main.go#L160-L164

      the service then terminates successfully and the fact that a failure occurred when overriding the installConfig is lost.

              zabitter Zane Bitter
              bfournie@redhat.com Robert Fournier
              None
              None
              Manoj Hans Manoj Hans
              None
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: