Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-69645

MAPO creates events when reconciling machines

XMLWordPrintable

    • None
    • None
    • ShiftStack Sprint 281, ShiftStack Sprint 285
    • 2
    • In Progress
    • Bug Fix
    • Hide
      Before this update, the Machine API Provider OpenStack (MAPO) created an event for every single reconcile, even when no significant state changes like creation, update, or deletion had occurred. This excessive event generation led to significant noise in event logs, created potential performance overhead, and frequently disrupted monitoring and alerting systems. With this release, the reconcile function has been modified to capture the original `ResourceVersion` and only emit an event when the machine `ResourceVersion` changes, indicating an actual modification. Additionally, the event name was changed from `Reconciled` to `Updated` to better align with other machine API providers. As a result, MAPO no longer creates unnecessary events during reconciliation cycles, ensuring events are recorded only when a machine is actually updated. (link:https://issues.redhat.com/browse/OCPBUGS-69645[OCPBUGS-69645])
      Show
      Before this update, the Machine API Provider OpenStack (MAPO) created an event for every single reconcile, even when no significant state changes like creation, update, or deletion had occurred. This excessive event generation led to significant noise in event logs, created potential performance overhead, and frequently disrupted monitoring and alerting systems. With this release, the reconcile function has been modified to capture the original `ResourceVersion` and only emit an event when the machine `ResourceVersion` changes, indicating an actual modification. Additionally, the event name was changed from `Reconciled` to `Updated` to better align with other machine API providers. As a result, MAPO no longer creates unnecessary events during reconciliation cycles, ensuring events are recorded only when a machine is actually updated. (link: https://issues.redhat.com/browse/OCPBUGS-69645 [ OCPBUGS-69645 ])
    • None
    • None
    • None
    • None

      This is a clone of issue OCPBUGS-69644. The following is the description of the original issue:
      —
      This is a clone of issue OCPBUGS-67298. The following is the description of the original issue:
      —
      As seen in the ovn-serial jobs, the test [sig-arch] events should not repeat pathologically for ns/openshift-machine-api fails with:

      {  1 events happened too frequently

event happened 21 times, something is wrong: namespace/openshift-machine-api hmsg/c0adc236e5 machine/k2yrry07-92bf1-wbbqt-worker-0-c85q8 - reason/Reconciled Reconciled machine k2yrry07-92bf1-wbbqt-worker-0-c85q8 (01:41:41Z) result=reject }

      That's because MAPO creates an event for each reconcile. We should only create events for Creation / Update / Deletion, as other providers do.

      https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-shiftstack-ci-release-4.20-e2e-openstack-ovn-serial/1999236006368251904

              maandre@redhat.com Martin André
              maandre@redhat.com Martin André
              Daniel Lawton Daniel Lawton
              None
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated: