Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-6700

Cluster-ingress-operator's updateIngressClass function logs success message when error

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • 4.13
    • Networking / router
    • None
    • Informational
    • None
    • Sprint 231, Sprint 232
    • 2
    • Rejected
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, a success message was displayed for the `updateIngressClass` function logs of the Ingress Operator when an error message should be displayed. With this update, the log message for Ingress Operator is accurate. (link:https://issues.redhat.com/browse/OCPBUGS-6700[*OCPBUGS-6700*])
      Show
      * Previously, a success message was displayed for the `updateIngressClass` function logs of the Ingress Operator when an error message should be displayed. With this update, the log message for Ingress Operator is accurate. (link: https://issues.redhat.com/browse/OCPBUGS-6700 [* OCPBUGS-6700 *])
    • Bug Fix
    • Done

      Description of problem:

      The cluster-ingress-operator's udpateIngressClass function logs "updated IngressClass" on a failure, when it should be logging that on a success.

      Version-Release number of selected component (if applicable):

      4.8+

      How reproducible:

      Easily

      Steps to Reproduce:

      # Simulate a change in an ingressclass that will be reconciled
      oc apply -f - <<EOF                                                                                                                 apiVersion: networking.k8s.io/v1
      kind: IngressClass
      metadata:
        name: openshift-default
      spec:
        controller: openshift.io/ingress-to-route
        parameters:
          apiGroup: operator.openshift.io
          kind: IngressController
          name: default
          scope: Namespace 
          namespace: "test"
      EOF
      
      # Look at logs
      oc logs -n openshift-ingress-operator $(oc get -n openshift-ingress-operator pods --no-headers | head -1 | awk '{print $1}') -c ingress-operator | grep "updated IngressClass"
      
      #No output

      Actual results:

      <none>

      Expected results:

      2023-01-26T20:37:19.210Z    INFO    operator.ingressclass_controller    ingressclass/ingressclass.go:63    updated IngressClass ...

      Additional info:

       

              gspence@redhat.com Grant Spence
              gspence@redhat.com Grant Spence
              Hongan Li Hongan Li
              Joe Aldinger Joe Aldinger
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: