Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-64726

OLMv1 crdUpgradeSafety fails due to unhandled Pattern changes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • 4.20.z
    • OLM
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None
    • Rejected
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      unhandled validation pattern change

      Version-Release number of selected component (if applicable):

          

      How reproducible:

      100%

      Steps to Reproduce:

          1. install a CRD where one of the fields has a validation pattern
          2. upgrade the CRD to a version where the field no longer has a pattern
          

      Actual results:

      v1alpha1: ^.spec.central.persistence.persistentVolumeClaim.size: unhandled: unhandled changes found (Pattern `^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$` -> "")
          

      Expected results:

      something that does not mention "unhandled"    

      Additional info:

      Not sure what the rules should be, as it might be hard to programatically establish whether the change relaxes the validation or makes it stricter (or both!).
      FTR this particular change was a mistake, as it is a long-unused field and leaving the validation around would have no bad consequences.

       

              rh-ee-cchantse Catherine Chan-Tse
              mowsiany@redhat.com Marcin Owsiany
              None
              None
              Xia Zhao Xia Zhao
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: