Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-63704

Remove unneeded params in agent-installer-utils Makefile

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None
    • Agent Sprint 279
    • 1
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      There are a few fields in the agent-installer-utils Makeflle that were needed when doing a nested "podman run" in the appliance. These are no longer necessary since the appliance uses the registry binary directly and does not require the podman run.

      Note that

      --storage-driver vfs
      

      is NOT one of the fields that can be removed. This is needed since the appliance still needs to do a "podman build" for the registry and removing this can result in errors like:

      using mount program /usr/bin/fuse-overlayfs: fuse: device not found, try 'modprobe fuse' first
      level=fatal msg=fuse-overlayfs: cannot mount: No such file or directory
      

      Using the vfs storage driver is also consistent with how Konflux runs buildah to build the container image. See https://github.com/konflux-ci/build-definitions/blob/main/.tekton/tasks/buildah.yaml#L22-L25 and https://github.com/konflux-ci/build-definitions/tree/main/pipelines/docker-build-multi-platform-oci-ta#build-image-index01-task-parameters

              bfournie@redhat.com Robert Fournier
              bfournie@redhat.com Robert Fournier
              None
              None
              Manoj Hans Manoj Hans
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: