Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-63691

node-ca's certificate update is racy

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • 4.18.z
    • Image Registry
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      (Please reassign to the correct component if I got it wrong)

      Description of problem:

      https://github.com/openshift/cluster-image-registry-operator/blob/2212ae9c5d1b1dfeaf2036677428968a031335f5/bindata/nodecadaemon.yaml#L54 is not atomic: looking at strace, it uses openat(AT_FDCWD, "a", O_WRONLY|O_TRUNC) in -place, so concurrent readers of the certificate can see an empty file or a partial certificate.
      
      Found in https://issues.redhat.com/browse/OCPBUGS-58262 .

      Version-Release number of selected component (if applicable):

      723cdc479e5092830af1c5fd3715a8560d284d16

      How reproducible:

      Unknown, by code inspection   

      Steps to Reproduce:

      N/A   

      Actual results:

      N/A

      Expected results:

      N/A

      Additional info:

          

              fmissi Flavian Missi
              rhn-engineering-mitr Miloslav Trmač
              None
              None
              XiuJuan Wang XiuJuan Wang
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: