Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-62794

PinnedImageSet (PIS) Inheritance for Custom MachineConfigPools

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.17.z, 4.16.z, 4.18.z, 4.19.z, 4.20.z, 4.21.0
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Background: This concern was raised during the review of PR #5333 in this comment: https://github.com/openshift/machine-config-operator/pull/5333#discussion_r2408616988

      Problem: The current implementation uses GetPoolsForNode for PinnedImageSet (PIS) detection. This function implies an inheritance model similar to how MachineConfigs are handled, where a custom pool (e.g., an infra node pool) might be considered a "worker" for the purpose of PIS.

      This can lead to unintended behavior. For example, a custom pool might inherit and pull PinnedImageSets from the base worker pool, even if it has its own distinct image requirements or no PIS needs at all. This is especially problematic if the custom pool uses a different base image, as it could result in pulling unnecessary or conflicting images.

      Questions to Investigate:

      1. Is this inheritance model for PinnedImageSets intentional?
      1. What is the expected workflow for a custom pool that requires a different set of PinnedImageSets than the main worker pool?
      1. Should the logic be adjusted to prevent custom pools from automatically inheriting PIS from their base pools?

      This behavior is not causing an immediate bug but could lead to confusion and unexpected resource consumption. We should clarify the intended design and adjust the implementation if necessary.

              team-mco Team MCO
              rh-ee-pabrodri Pablo Rodriguez Nava
              None
              None
              Sergio Regidor de la Rosa Sergio Regidor de la Rosa
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: