Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-62324

Hypershift e2e binary: annotations flag not parsed correctly

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • 4.21.0
    • 4.21
    • HyperShift
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      The -e2e.annotations flag is parsed by splitting the string using = as a separator. This does not work properly when the flag value itself also contains a = character, for example:
      
      -e2e.annotations "hypershift.openshift.io/image-overrides=my-component=my-image"

      Version-Release number of selected component (if applicable):

      Hypershift Git version: v0.1.68-105-gdb76a89d8

      How reproducible:

      Always

      Steps to Reproduce:

      Run the test-e2e binary passing the -e2e.annotations flag with a value that has 2+ = characters.
      
          

      Actual results:

      Flag value is split at every = character, resulting in 3+ strings and erroring out with message:
      
      invalid value "hypershift.openshift.io/image-overrides=my-component=my-image" for flag -e2e.annotations:
        invalid argument: my-component=my-image 

      Expected results:

      Flag is parsed correctly and split only at the first = character.

              rh-ee-bclement Borja Clemente Castanera
              rh-ee-bclement Borja Clemente Castanera
              None
              None
              Yu Li Yu Li
              None
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: