-
Bug
-
Resolution: Done
-
Major
-
None
-
4.20, 4.21.0
-
Quality / Stability / Reliability
-
False
-
-
0
-
Moderate
-
None
-
None
-
Rejected
-
OAPE Sprint 277
-
1
-
In Progress
-
Release Note Not Required
-
N/A
-
None
-
None
-
None
-
None
This is a clone of issue OCPBUGS-61571. The following is the description of the original issue:
—
Description of problem:
Running `make` now fails on non-fips systems:
$ make
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x3 pc=0x819ee1]goroutine 1 [running]:
cmd/go/internal/fips140.Init()
cmd/go/internal/fips140/fips140.go:117 +0x101
cmd/go/internal/modload.Init()
cmd/go/internal/modload/init.go:419 +0x33
cmd/go/internal/toolchain.Exec({0xc000162802, 0x8})
cmd/go/internal/toolchain/select.go:356 +0x3fc
cmd/go/internal/toolchain.Select()
cmd/go/internal/toolchain/select.go:284 +0x11a5
main.main()
cmd/go/main.go:107 +0x4f
vendor/github.com/openshift/build-machinery-go/make/targets/golang/build.mk:15: *** no packages to build: GO_BUILD_PACKAGES_EXPANDED var is empty. Stop.
Because these lines in the Makefile override the default values from golang.mk:
https://github.com/openshift/secrets-store-csi-driver-operator/blob/0c7ce67ad1a1b4b19941ca7df7cacac9c88e441c/Makefile#L11-L12
It's possible to set GO back to the default, and the build succeeds:
$ make GO=go
fatal: No names found, cannot describe anything.
go build -mod=vendor -trimpath -tags strictfipsruntime,openssl -ldflags "-X github.com/openshift/secrets-store-csi-driver-operator/pkg/version.versionFromGit="v0.0.0-unknown-b5067785" -X github.com/openshift/secrets-store-csi-driver-operator/pkg/version.commitFromGit="b5067785" -X github.com/openshift/secrets-store-csi-driver-operator/pkg/version.gitTreeState="clean" -X github.com/openshift/secrets-store-csi-driver-operator/pkg/version.buildDate="2025-09-11T15:04:39Z" " github.com/openshift/secrets-store-csi-driver-operator/cmd/secrets-store-csi-driver-operator
Those Makefile lines were introduced in https://github.com/openshift/secrets-store-csi-driver-operator/pull/79
Can this be done in a way that doesn't break builds on non-fips systems?
Version-Release number of selected component (if applicable):
4.20
How reproducible:
100%
Steps to Reproduce:
1. run `make`
2.
3.
Actual results:
build fails
Expected results:
build succeeds
Additional info:
- clones
-
OCPBUGS-61571 SSCSI driver operator: default make is broken on non-fips systems
-
- Verified
-
- is blocked by
-
OCPBUGS-61571 SSCSI driver operator: default make is broken on non-fips systems
-
- Verified
-
- links to