Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-60119

Invalid architecture value found in annotation during 4.19 update

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • 2
    • Important
    • None
    • None
    • MCO Sprint 275
    • 1
    • Done
    • Bug Fix
    • Hide
      During an update from 4.18.21 to 4.19.6, the Machine Config Operator failed due to multiple labels in the `capacity.cluster-autoscaler.kubernetes.io/labels` annotation in one or more machine sets. The Machine Config Operator now accepts multiple labels in the `capacity.cluster-autoscaler.kubernetes.io/labels` annotation. With this fix, the Machine Config Operator no longer fails during the update to 4.19.6. (link:https://issues.redhat.com/browse/OCPBUGS-60119[OCPBUGS-60119])
      Show
      During an update from 4.18.21 to 4.19.6, the Machine Config Operator failed due to multiple labels in the `capacity.cluster-autoscaler.kubernetes.io/labels` annotation in one or more machine sets. The Machine Config Operator now accepts multiple labels in the `capacity.cluster-autoscaler.kubernetes.io/labels` annotation. With this fix, the Machine Config Operator no longer fails during the update to 4.19.6. (link: https://issues.redhat.com/browse/OCPBUGS-60119 [ OCPBUGS-60119 ])

      During the update from 4.18.21 to 4.19.6, the machine-config operator fails with the following error message if one or more MachineSets contain more than the expected arch label in the capacity.cluster-autoscaler.kubernetes.io/labels annotation, e.g.:

      apiVersion: machine.openshift.io/v1beta1
      kind: MachineSet
      metadata:
        annotations:
          ...
          capacity.cluster-autoscaler.kubernetes.io/labels: kubernetes.io/arch=amd64,topology.ebs.csi.aws.com/zone=eu-central-1a 

      The error message:

      Unable to apply 4.19.6: 
      bootimage update failed: 6 Degraded MAPI MachineSets | 0 Degraded CAPI MachineSets | 0 CAPI MachineDeployments | 
      Error(s): [error syncing MAPI MachineSet worker-app-b-0-arm: failed to fetch arch during machineset sync: 
      invalid architecture value found in annotation: 
      kubernetes.io/arch=arm64,topology.kubernetes.io/zone=eu-central-1b,topology.ebs.csi.aws.com/zone=eu-central-1b , 
      error syncing MAPI MachineSet worker-app-c-0-arm: 
      failed to fetch arch during machineset sync: 
      invalid architecture value found in annotation: kubernetes.io/arch=arm64,topology.ebs.csi.aws.com/zone=eu-central-1c,topology.kubernetes.io/zone=eu-central-1c , 
      error syncing MAPI MachineSet worker-batch-a-0: 
      failed to fetch arch during machineset sync: 
      invalid architecture value found in annotation: kubernetes.io/arch=amd64,topology.ebs.csi.aws.com/zone=eu-central-1a , 
      error syncing MAPI MachineSet worker-app-a-0: 
      failed to fetch arch during machineset sync: 
      invalid architecture value found in annotation: kubernetes.io/arch=amd64,topology.ebs.csi.aws.com/zone=eu-central-1a , 
      error syncing MAPI MachineSet worker-app-a-0-arm: 
      failed to fetch arch during machineset sync: 
      invalid architecture value found in annotation: kubernetes.io/arch=arm64,topology.ebs.csi.aws.com/zone=eu-central-1a , 
      error syncing MAPI MachineSet worker-app-b-0: 
      failed to fetch arch during machineset sync: 
      invalid architecture value found in annotation: kubernetes.io/arch=amd64,topology.ebs.csi.aws.com/zone=eu-central-1b ]

      Looking at the code, it looks like we don't consider more than one label as value of the capacity.cluster-autoscaler.kubernetes.io/labels annotation: https://github.com/openshift/machine-config-operator/blob/e6cd1217fcccd61e840ac8e88276d873f83c1907/pkg/controller/machine-set-boot-image/ms_helpers.go#L252

       

              djoshy David Joshy
              rh-ee-baffolte Benjamin Affolter
              None
              None
              Sergio Regidor de la Rosa Sergio Regidor de la Rosa
              None
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

                Created:
                Updated: