Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-58467

[v2] --parallel-images flag have not check the valid min and max value

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • Moderate
    • No
    • None
    • None
    • CLID Sprint 273, CLID Sprint 274
    • 2
    • In Progress
    • Bug Fix
    • Hide
      * Before this update, the --parallel-images flag accepted invalid input, with minimum value less than 1 or greater than the total number of images. As a consequence, parallel image mirroring failed with 0 or 100 flags, limiting the number of images that could be mirrored. With this release, the issue with invalid --parallel-images flags has been fixed, now accepting values between 1 and the total number of images. As a result, the user experience is improved by preventing unexpected errors during image mirroring.
      link:https://issues.redhat.com/browse/OCPBUGS-58467(OCPBUGS-58467)
      Show
      * Before this update, the --parallel-images flag accepted invalid input, with minimum value less than 1 or greater than the total number of images. As a consequence, parallel image mirroring failed with 0 or 100 flags, limiting the number of images that could be mirrored. With this release, the issue with invalid --parallel-images flags has been fixed, now accepting values between 1 and the total number of images. As a result, the user experience is improved by preventing unexpected errors during image mirroring. link: https://issues.redhat.com/browse/OCPBUGS-58467(OCPBUGS-58467)
    • None
    • None
    • None
    • None

      Description of problem:

      --parallel-images flag with 0 or 100 have error

      Version-Release number of selected component (if applicable):

       4.19   

      How reproducible:

       Always   

      Steps to Reproduce:

      1. create isc.yaml
      kind: ImageSetConfiguration
      apiVersion: mirror.openshift.io/v2alpha1
      mirror:
        operators:
          - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.17
            packages:
             - name: aws-load-balancer-operator
      2. 。/oc-mirror -c isc.yaml file://test --parallel-images 100 --v2
      3. 。/oc-mirror -c isc.yaml file://test --parallel-images 0 --v2     

      Actual results:

       $ ./oc-mirror -c isc.yaml file://test --parallel-images 100 --v2
      2025/07/08 06:38:51  [INFO]   : 👋 Hello, welcome to oc-mirror
      2025/07/08 06:38:51  [INFO]   : ⚙️  setting up the environment for you...
      2025/07/08 06:38:51  [INFO]   : 🔀 workflow mode: mirrorToDisk 
      2025/07/08 06:38:51  [INFO]   : 🕵  going to discover the necessary images...
      2025/07/08 06:38:51  [INFO]   : 🔍 collecting release images...
      2025/07/08 06:38:51  [INFO]   : 🔍 collecting operator images...
       ✓   (19s) Collecting catalog registry.redhat.io/redhat/redhat-operator-index:v4.17 
      2025/07/08 06:39:10  [INFO]   : 🔍 collecting additional images...
      2025/07/08 06:39:10  [INFO]   : 🔍 collecting helm images...
      2025/07/08 06:39:10  [INFO]   : 🔂 rebuilding catalogs
       ✓   () Rebuilding catalog docker://registry.redhat.io/redhat/redhat-operator-index:v4.17 
      2025/07/08 06:39:10  [INFO]   : 🚀 Start copying the images...
      2025/07/08 06:39:10  [INFO]   : 📌 images to copy 21 
       ✓   (1s) aws-load-balancer-operator-bundle@sha256:59ff4966f4f653e49d42d97bfed6351d3730128db74f666ee4ecacff11790baf ➡️  cache 
       ✓   (1s) aws-load-balancer-operator-bundle@sha256:50b9402635dd4b312a86bed05dcdbda8c00120d3789ec2e9b527045100b3bdb4 ➡️  cache 
       ✓   (1s) aws-load-balancer-rhel8-operator@sha256:53f14e88f05641545b675ff4edbcff6909d752659c02a1babf7491734f347153 ➡️  cache 
       ✓   (1s) aws-load-balancer-operator-bundle@sha256:3939323bc858e2a71b9ef0f858c5020ffd501e664a3652bd0be5f17176eb63f5 ➡️  cache 
       ✓   (1s) aws-load-balancer-rhel8-operator@sha256:95c45fae0ca9e9bee0fa2c13652634e726d8133e4e3009b363fcae6814b3461d ➡️  cache 
       ✓   (1s) aws-load-balancer-rhel8-operator@sha256:16e9ffed36107527a37713ac5bd34a7bc20f042269a81077429fb5884914c4d0 ➡️  cache 
       ✓   (1s) aws-load-balancer-rhel8-operator@sha256:ab38b37c14f7f0897e09a18eca4a232a6c102b76e9283e401baed832852290b5 ➡️  cache 
       ✓   (1s) aws-load-balancer-operator-bundle@sha256:01f2ca529d2486f113bcefc9fedce6a6fd07bcb48aaf534394b5b04c353f8853 ➡️  cache 
       ✓   (1s) aws-load-balancer-rhel8-operator@sha256:6e15df39a3d25755a79888f739e1af8b052c3fba57bf8f6b3434ef58fd4288cf ➡️  cache 
       ✓   (2s) aws-load-balancer-controller-rhel8@sha256:f0b47b8200f85b557497a4f03d7b186cf415c4137e9cc0361633b67891cf2a24 ➡️  cache 
       ✓   (2s) aws-load-balancer-controller-rhel8@sha256:2e0b9332a44d8d9c23e19c7accab0813a651f39210257820db508cac28876595 ➡️  cache 
       ✓   (2s) aws-load-balancer-controller-rhel8@sha256:cfd210a2cb705156883fda126d052e05eb84345cc27ba04688067f8ed9a802ea ➡️  cache 
       ✓   (2s) aws-load-balancer-controller-rhel8@sha256:d7bc364512178c36671d8a4b5a76cf7cb10f8e56997106187b0fe1f032670ece ➡️  cache 
       ✓   (2s) aws-load-balancer-operator-bundle@sha256:e371c45e259eaf54d79b1bfc6c47b1093d87965a8d6076205d4860047146ed43 ➡️  cache 
       ✓   (3s) aws-load-balancer-controller-rhel8@sha256:73db97d20ee9415e9a8941cc6a36ed81d901d760d9949e95e10c90866ef8bf64 ➡️  cache 
       ✓   (3s) ose-kube-rbac-proxy@sha256:4a2324acaea757bae3b01b1aec59f49f4dd79bd1868e69d3418d57c210a6dfd9 ➡️  cache 
       ✓   (5s) ose-kube-rbac-proxy@sha256:f11f71448986aa17abec9caadb568a6cc34ef1a7898e6dc20bc6a512830ba476 ➡️  cache 
       ✓   (5s) ose-kube-rbac-proxy@sha256:9f9f8f69ab98c1f25cc301572339e0cc5c5b76f2e29ed26e10ac91ad20e0090c ➡️  cache 
       ✓   (5s) ose-kube-rbac-proxy@sha256:3658954f199040b0f244945c94955f794ee68008657421002e1b32962e7c30fc ➡️  cache 
       ✓   (5s) ose-kube-rbac-proxy@sha256:e3dad360d0351237a16593ca0862652809c41a2127c2f98b9e0a559568efbd10 ➡️  cache 
      21 / 21 (5s) [==================================================================================================================================================================================================================] 100 %
       ✓   (5s) redhat-operator-index:v4.17 ➡️  cache 
      2025/07/08 06:39:17  [INFO]   : === Results ===
      2025/07/08 06:39:17  [INFO]   :  ✓  21 / 21 operator images mirrored successfully
      2025/07/08 06:39:17  [INFO]   : 📦 Preparing the tarball archive...
      2025/07/08 06:39:39  [INFO]   : mirror time     : 47.834740833s
      2025/07/08 06:39:39  [INFO]   : 👋 Goodbye, thank you for using oc-mirror
      
      $ ./oc-mirror -c isc.yaml file://test0 --parallel-images 0 --v2
      2025/07/08 07:08:34  [INFO]   : 👋 Hello, welcome to oc-mirror
      2025/07/08 07:08:34  [INFO]   : ⚙️  setting up the environment for you...
      2025/07/08 07:08:34  [INFO]   : 🔀 workflow mode: mirrorToDisk 
      2025/07/08 07:08:34  [INFO]   : 🕵  going to discover the necessary images...
      2025/07/08 07:08:34  [INFO]   : 🔍 collecting release images...
      2025/07/08 07:08:34  [INFO]   : 🔍 collecting operator images...
       ✓   (23s) Collecting catalog registry.redhat.io/redhat/redhat-operator-index:v4.17 
      2025/07/08 07:08:58  [INFO]   : 🔍 collecting additional images...
      2025/07/08 07:08:58  [INFO]   : 🔍 collecting helm images...
      2025/07/08 07:08:58  [INFO]   : 🔂 rebuilding catalogs
       ✓   (0s) Rebuilding catalog docker://registry.redhat.io/redhat/redhat-operator-index:v4.17 
      2025/07/08 07:08:58  [INFO]   : 🚀 Start copying the images...
      2025/07/08 07:08:58  [INFO]   : 📌 images to copy 21  0 / 21 (3m17s) [------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 0 %   

      Expected results:

      prompt the valid max is the total images number (21)
      prompt the valid min is 1, 
          

      Additional info:

          

              luzuccar@redhat.com Luigi Mario Zuccarelli
              maxu@redhat.com May Xu
              None
              None
              May Xu May Xu
              None
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: