Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-57177

Applying an invalid PIS should degrade an MCP

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • 2
    • Moderate
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      As discussed in this Slack thread, the general consensus from the MCO team is that applying an invalid PinnedImageSet should result in degrading the targeted MCP. Due to a faulting conditional that the PIS to MCP degrade functionality is nested under, this is not the currently observed functionality.

      Version-Release number of selected component (if applicable):

      Definitely 4.19 & 4.20, other versions need to be tested.

      How reproducible:

      Always.

      Steps to Reproduce:

      1. Launch a 4.19 or 4.20 cluster with tech preview enabled.

      2. Apply an invalid PIS, such as the below example.

      apiVersion: machineconfiguration.openshift.io/v1
      kind: PinnedImageSet
      metadata:
        name: test-pinned
        labels:
          machineconfiguration.openshift.io/role: "worker"
      spec:
        pinnedImages:
         - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
         - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

      3. Wait for the PIS application to fail. The PIS degrade condition can be checked in the MachineConfigNode conditions list.

      $ oc describe machineconfignodes/<node-name>
      ...
      Status:
        Conditions:
      ...
          Last Transition Time:  2025-06-06T13:50:42Z
          Message:               One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details.
          Reason:                PrefetchFailed
          Status:                True
          Type:                  PinnedImageSetsDegraded
      ...

      Actual results:

      The PIS will fail to apply, but the targeted MCP machines will not show as being degraded. Also, the `` condition is not showing as "True" in the MCP describe.

      $ oc get mcp
      NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
      master   rendered-master-169b80827b765910c1b7b70df469d710   True      False      False      3              3                   3                     0                      33m
      worker   rendered-worker-33b4cdc1daa04d6771b7915f84666920   True      False      False      3              3                   3                     0                      33m
      
      $ oc describe mcp/worker
      ...
      ...
      Status:   Conditions:
      ...
          Last Transition Time:  2025-06-06T13:19:37Z
          Message:               
          Reason:                
          Status:                False
          Type:                  PinnedImageSetsDegraded
      ...
          Last Transition Time:  2025-06-06T13:19:42Z
          Message:               
          Reason:                
          Status:                False
          Type:                  Degraded

      Expected results:

      The MCP and machines targeted by a PIS should degrade is the PIS is invalid and the images fail to pull and/or pin.

      Additional info:

      N/A

              rh-ee-ijanssen Isabella Janssen
              rh-ee-ijanssen Isabella Janssen
              None
              None
              Sergio Regidor de la Rosa Sergio Regidor de la Rosa
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: