The migration controllers shortcut reconciliation if their status indicate prior success. Therefore setting this status must be the last thing the controller does after all work is complete.We were unpausing after setting completion status. Therefore if we failed to set unpause due to, e.g. an epheral api-server issue, we would never retry.

4.20.0    

    Hard to reproduce, only the unpausing would need to fail to trigger this issue

    1. Migrate a resource from MAPI to CAPI 
    2. Somehow fail to unpause resource
    3.
    

    CAPI resource stays paused and never gets unpaused

    The unpausing is retried and the CAPI resource is eventually unpaused