Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-56820

[release-4.18] OLMv1: faulty parsing of olm.maxOpenShiftVersion allows cluster upgrades when they should be blocked

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • None
    • 4.18
    • OLM
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • Rejected
    • Lillipup Sprint 272
    • 1
    • In Progress
    • Bug Fix
    • Hide
      *Cause*: What actions or circumstances cause this bug to present.
      *Consequence*: What happens when the bug presents.
      *Fix*: What was done to fix the bug.
      *Result*: Bug doesn’t present anymore.
      Show
      *Cause*: What actions or circumstances cause this bug to present. *Consequence*: What happens when the bug presents. *Fix*: What was done to fix the bug. *Result*: Bug doesn’t present anymore.
    • None
    • None
    • None
    • None

      Our float parsing logic for olm.maxOpenShiftVersion has a bug related to floating-point math. For example:

      • 4.18 (float) parsed to 4.18.0 (semver), but
      • 4.19 (float) parsed to 4.20.0 (semver)

      This PR resolves that bug, adds regression tests, and also does some slight refactoring to make the overall max OCP version logic easier to understand for maintainers.

      NOTE: This may not actually be reproducible on 4.18 with any operators current in the catalog since it seems like our buggy logic happens to work with a floating point value like `4.18`. However, there are likely other inputs that trigger similar bugs, so we want to proactively fix this bug in 4.18 because we know that our floating point math-based parsing is fundamentally flawed.

       

       

              rh-ee-cchantse Catherine Chan-Tse
              sgoeddel@redhat.com Stephen Goeddel
              None
              None
              Xia Zhao Xia Zhao
              None
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: