Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-56451

Installer should parse the mirrorSourcePolicy field under imageDigestSources

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None
    • Installer Sprint 272, Installer Sprint 273, Installer Sprint 274, Installer Sprint 275, Installer Sprint 276, Installer Sprint 277, Installer Sprint 278, Installer Sprint 279
    • 8
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      installer does not parse and include the "mirrorSourcePolicy" field under imageDigestSources. This means that we cannot use the "mirrorSourcePolicy: NeverContactSource" setting that IDMS support.    

      Version-Release number of selected component (if applicable):

          4.18

      How reproducible:

          100%

      Steps to Reproduce:

          1. Add The following to an install-config.yaml
      
      imageDigestSources:
      - mirrors:
        - private.registry.io:5000/openshift
        source: quay.io/openshift-release-dev/ocp-release
        mirrorSourcePolicy: NeverContactSource
      
      
          2. Generate manifests with the command: openshift-install generate manifests --dir=/path/to/installconfig
          3.
          

      Actual results:

          openshift-installer has a 0 return code but with the following warning message "WARNING failed to parse first occurrence of unknown field: failed to unmarshal install-config.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field "mirrorSourcePolicy""
      
          The installer also does not add those fields to the manifest file idms_testing/manifests/image-digest-mirror-set.yaml. We can see that it only has the mappings
      
      
      apiVersion: config.openshift.io/v1
      kind: ImageDigestMirrorSet
      metadata:
        creationTimestamp: null
        name: image-digest-mirror
      spec:
        imageDigestMirrors:
        - mirrors:
          - private.registry.io:5000/openshift
          source: quay.io/openshift-release-dev/ocp-release
        - mirrors:
          - private.registry.io:5000/openshift
          source: quay.io/openshift-release-dev/ocp-v4.0-art-dev
      status: {}
      

      Expected results:

          The installer will parse and include the "mirrorSourcePolicy" field, supported by ImageDigestMirrorSet, when included in the install-config.yaml

      Additional info:

      We have run into a bunch of situations where contacting the original source causes issues if someone has taken over quay.io on a private network and is pointing it to some other registry which is not the private registry that the customer is using.    

              sdasu@redhat.com Sandhya Dasu
              dan5179 Dan Clark
              None
              None
              Gaoyun Pei Gaoyun Pei
              None
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: