Loading...

XML

Word

Printable

Type: Bug
Resolution: Done
Priority: Undefined
Fix Version/s: 4.20.0
Affects Version/s: 4.19
Component/s: Cloud Compute / Cluster API Providers
Labels:
- pre-merge-tested

Activity Type:
Quality / Stability / Reliability
Blocked:
False
Blocked Reason:

Hide

None

Show
None
Story Points:
None
Severity:
Important
Regression:
None

Target Backport Versions:

4.19.z
Target Version:

4.20.0
Release Blocker:
Rejected
Sprint:
CLOUD Sprint 270, CLOUD Sprint 271
sprint_count:
2

SFDC Cases Counter:
SFDC Cases Open:
SFDC Cases Links:

Release Note Status:
Done
Release Note Type:
Bug Fix
Release Note Text:

Hide
* Before this update, on clusters that support migrating Machine API resources to Cluster API resources, deleting a nonauthoritative machine did not delete the corresponding authoritative machine.
As a consequence, orphaned machines that should have been cleaned up remained on the cluster and could cause resource leak.
With this release, deleting a nonauthoritative machine triggers propagation of the deletion to the corresponding authoritative machine.
As a result, deletion requests on nonauthoritative machine correctly cascade, preventing orphaned authoritative machines and ensuring consistency in machine cleanup.
(link:https://issues.redhat.com/browse/OCPBUGS-55985[~~OCPBUGS-55985~~])

Show
* Before this update, on clusters that support migrating Machine API resources to Cluster API resources, deleting a nonauthoritative machine did not delete the corresponding authoritative machine. As a consequence, orphaned machines that should have been cleaned up remained on the cluster and could cause resource leak. With this release, deleting a nonauthoritative machine triggers propagation of the deletion to the corresponding authoritative machine. As a result, deletion requests on nonauthoritative machine correctly cascade, preventing orphaned authoritative machines and ensuring consistency in machine cleanup. (link: https://issues.redhat.com/browse/OCPBUGS-55985 [ OCPBUGS-55985 ])

Escape Reason:
None
Escape Impact:
None
Corrective Measures:
None
SDLC stage when should've been found:
None

Description of problem:

    When .spec.authoritativeAPI: MachineAPI and spec.template.spec.authoritativeAPI: ClusterAPI , the CAPI-authoritative Machine cannot be scale down

Version-Release number of selected component (if applicable):

    4.19.0-0.nightly-2025-05-08-151714

How reproducible:

    always

Steps to Reproduce:

    1.At the very beginning, there is a MachineSet which .spec.authoritativeAPI: MachineAPI and
 spec.template.spec.authoritativeAPI: MachineAPI , its replicas: 1 and there is a MAPI-authoritative Machine. 

liuhuali@Lius-MacBook-Pro huali-test % oc get machine
NAME                                          PHASE     TYPE         REGION      ZONE         AGE
huliu-aws509a-59qsm-master-hkl2b-0            Running   m6i.xlarge   us-east-2   us-east-2a   27m
huliu-aws509a-59qsm-master-rpkn4-2            Running   m6i.xlarge   us-east-2   us-east-2c   79m
huliu-aws509a-59qsm-master-xpcgm-1            Running   m6i.xlarge   us-east-2   us-east-2b   108m
huliu-aws509a-59qsm-worker-us-east-2a-xjft7   Running   m6i.xlarge   us-east-2   us-east-2a   3h41m
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   Running   m6i.xlarge   us-east-2   us-east-2b   3h41m
huliu-aws509a-59qsm-worker-us-east-2c-47n92   Running   m6i.xlarge   us-east-2   us-east-2c   3h41m

    2.Update the MachineSet to .spec.authoritativeAPI: MachineAPI and spec.template.spec.authoritativeAPI: ClusterAPI , update successfully 

liuhuali@Lius-MacBook-Pro huali-test % oc edit machineset huliu-aws509a-59qsm-worker-us-east-2a
machineset.machine.openshift.io/huliu-aws509a-59qsm-worker-us-east-2a edited
liuhuali@Lius-MacBook-Pro huali-test % oc get machineset huliu-aws509a-59qsm-worker-us-east-2a -oyaml|grep authoritativeAPI
  authoritativeAPI: MachineAPI
      authoritativeAPI: ClusterAPI
  authoritativeAPI: MachineAPI

    3.Scale up the MachineSet, a new machine created, it's CAPI-authoritative Machine. The MachineSet replicas: 2 , it contains 1 MAPI-authoritative Machine and 1 CAPI-authoritative Machine.   

liuhuali@Lius-MacBook-Pro huali-test % oc scale machineset huliu-aws509a-59qsm-worker-us-east-2a --replicas=2
machineset.machine.openshift.io/huliu-aws509a-59qsm-worker-us-east-2a scaled

liuhuali@Lius-MacBook-Pro huali-test % oc get machineset
NAME                                    DESIRED   CURRENT   READY   AVAILABLE   AGE
huliu-aws509a-59qsm-worker-us-east-2a   2         2         2       2           4h22m
huliu-aws509a-59qsm-worker-us-east-2b   1         1         1       1           4h22m
huliu-aws509a-59qsm-worker-us-east-2c   1         1         1       1           4h22m  
liuhuali@Lius-MacBook-Pro huali-test % oc get machine
NAME                                          PHASE     TYPE         REGION      ZONE         AGE
huliu-aws509a-59qsm-master-hkl2b-0            Running   m6i.xlarge   us-east-2   us-east-2a   67m
huliu-aws509a-59qsm-master-rpkn4-2            Running   m6i.xlarge   us-east-2   us-east-2c   119m
huliu-aws509a-59qsm-master-xpcgm-1            Running   m6i.xlarge   us-east-2   us-east-2b   148m
huliu-aws509a-59qsm-worker-us-east-2a-96dsv                                                   13m
huliu-aws509a-59qsm-worker-us-east-2a-xjft7   Running   m6i.xlarge   us-east-2   us-east-2a   4h21m
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   Running   m6i.xlarge   us-east-2   us-east-2b   4h21m
huliu-aws509a-59qsm-worker-us-east-2c-47n92   Running   m6i.xlarge   us-east-2   us-east-2c   4h21m

liuhuali@Lius-MacBook-Pro huali-test % oc get machineset.c -n openshift-cluster-api
NAME                                    CLUSTER               REPLICAS   READY   AVAILABLE   AGE     VERSION
huliu-aws509a-59qsm-worker-us-east-2a   huliu-aws509a-59qsm                                  4h14m   
huliu-aws509a-59qsm-worker-us-east-2b   huliu-aws509a-59qsm                                  4h14m   
huliu-aws509a-59qsm-worker-us-east-2c   huliu-aws509a-59qsm                                  4h14m   
liuhuali@Lius-MacBook-Pro huali-test % oc get machine.c -n openshift-cluster-api
NAME                                          CLUSTER               NODENAME                                    PROVIDERID                              PHASE     AGE    VERSION
huliu-aws509a-59qsm-worker-us-east-2a-96dsv   huliu-aws509a-59qsm   ip-10-0-12-140.us-east-2.compute.internal   aws:///us-east-2a/i-04366ac2513f8a679   Running   16m    
huliu-aws509a-59qsm-worker-us-east-2a-xjft7   huliu-aws509a-59qsm                                               aws:///us-east-2a/i-01dbe2f66b51afcd1             4h6m   
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   huliu-aws509a-59qsm                                               aws:///us-east-2b/i-09dcb479c39b9acf3             4h4m   
huliu-aws509a-59qsm-worker-us-east-2c-47n92   huliu-aws509a-59qsm                                               aws:///us-east-2c/i-039e58af6496362e4             4h4m   

4.Scale down the MachineSet, no machine was deleted. The MachineSet replicas: 1 , but it still contains 1 MAPI-authoritative Machine and 1 CAPI-authoritative Machine.

liuhuali@Lius-MacBook-Pro huali-test % oc scale machineset huliu-aws509a-59qsm-worker-us-east-2a --replicas=1
machineset.machine.openshift.io/huliu-aws509a-59qsm-worker-us-east-2a scaled

liuhuali@Lius-MacBook-Pro huali-test % oc get machine.c -n openshift-cluster-api
NAME                                          CLUSTER               NODENAME                                    PROVIDERID                              PHASE     AGE     VERSION
huliu-aws509a-59qsm-worker-us-east-2a-96dsv   huliu-aws509a-59qsm   ip-10-0-12-140.us-east-2.compute.internal   aws:///us-east-2a/i-04366ac2513f8a679   Running   25m     
huliu-aws509a-59qsm-worker-us-east-2a-xjft7   huliu-aws509a-59qsm                                               aws:///us-east-2a/i-01dbe2f66b51afcd1             4h16m   
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   huliu-aws509a-59qsm                                               aws:///us-east-2b/i-09dcb479c39b9acf3             4h13m   
huliu-aws509a-59qsm-worker-us-east-2c-47n92   huliu-aws509a-59qsm                                               aws:///us-east-2c/i-039e58af6496362e4             4h13m   
liuhuali@Lius-MacBook-Pro huali-test % oc get machine
NAME                                          PHASE     TYPE         REGION      ZONE         AGE
huliu-aws509a-59qsm-master-hkl2b-0            Running   m6i.xlarge   us-east-2   us-east-2a   79m
huliu-aws509a-59qsm-master-rpkn4-2            Running   m6i.xlarge   us-east-2   us-east-2c   131m
huliu-aws509a-59qsm-master-xpcgm-1            Running   m6i.xlarge   us-east-2   us-east-2b   161m
huliu-aws509a-59qsm-worker-us-east-2a-96dsv                                                   25m
huliu-aws509a-59qsm-worker-us-east-2a-xjft7   Running   m6i.xlarge   us-east-2   us-east-2a   4h33m
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   Running   m6i.xlarge   us-east-2   us-east-2b   4h33m
huliu-aws509a-59qsm-worker-us-east-2c-47n92   Running   m6i.xlarge   us-east-2   us-east-2c   4h33m
liuhuali@Lius-MacBook-Pro huali-test % oc get machineset
NAME                                    DESIRED   CURRENT   READY   AVAILABLE   AGE
huliu-aws509a-59qsm-worker-us-east-2a   1         1         1       1           4h37m
huliu-aws509a-59qsm-worker-us-east-2b   1         1         1       1           4h37m
huliu-aws509a-59qsm-worker-us-east-2c   1         1         1       1           4h37m

5.Continue scale down the MachineSet, the MAPI-authoritative Machine was deleted.  The MachineSet replicas: 0 , but it contains 1 CAPI-authoritative Machine.

liuhuali@Lius-MacBook-Pro huali-test % oc scale machineset huliu-aws509a-59qsm-worker-us-east-2a --replicas=0
machineset.machine.openshift.io/huliu-aws509a-59qsm-worker-us-east-2a scaled
liuhuali@Lius-MacBook-Pro huali-test % oc get machine
NAME                                          PHASE      TYPE         REGION      ZONE         AGE
huliu-aws509a-59qsm-master-hkl2b-0            Running    m6i.xlarge   us-east-2   us-east-2a   80m
huliu-aws509a-59qsm-master-rpkn4-2            Running    m6i.xlarge   us-east-2   us-east-2c   132m
huliu-aws509a-59qsm-master-xpcgm-1            Running    m6i.xlarge   us-east-2   us-east-2b   161m
huliu-aws509a-59qsm-worker-us-east-2a-96dsv                                                    26m
huliu-aws509a-59qsm-worker-us-east-2a-xjft7   Deleting   m6i.xlarge   us-east-2   us-east-2a   4h34m
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   Running    m6i.xlarge   us-east-2   us-east-2b   4h34m
huliu-aws509a-59qsm-worker-us-east-2c-47n92   Running    m6i.xlarge   us-east-2   us-east-2c   4h34m
liuhuali@Lius-MacBook-Pro huali-test % oc get machine                                   
NAME                                          PHASE     TYPE         REGION      ZONE         AGE
huliu-aws509a-59qsm-master-hkl2b-0            Running   m6i.xlarge   us-east-2   us-east-2a   86m
huliu-aws509a-59qsm-master-rpkn4-2            Running   m6i.xlarge   us-east-2   us-east-2c   138m
huliu-aws509a-59qsm-master-xpcgm-1            Running   m6i.xlarge   us-east-2   us-east-2b   168m
huliu-aws509a-59qsm-worker-us-east-2a-96dsv                                                   32m
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   Running   m6i.xlarge   us-east-2   us-east-2b   4h40m
huliu-aws509a-59qsm-worker-us-east-2c-47n92   Running   m6i.xlarge   us-east-2   us-east-2c   4h40m
liuhuali@Lius-MacBook-Pro huali-test % oc get machineset
NAME                                    DESIRED   CURRENT   READY   AVAILABLE   AGE
huliu-aws509a-59qsm-worker-us-east-2a   0         0                             4h44m
huliu-aws509a-59qsm-worker-us-east-2b   1         1         1       1           4h44m
huliu-aws509a-59qsm-worker-us-east-2c   1         1         1       1           4h44m
liuhuali@Lius-MacBook-Pro huali-test % oc get machine.c -n openshift-cluster-api   
NAME                                          CLUSTER               NODENAME                                    PROVIDERID                              PHASE     AGE     VERSION
huliu-aws509a-59qsm-worker-us-east-2a-96dsv   huliu-aws509a-59qsm   ip-10-0-12-140.us-east-2.compute.internal   aws:///us-east-2a/i-04366ac2513f8a679   Running   36m     
huliu-aws509a-59qsm-worker-us-east-2b-fdhml   huliu-aws509a-59qsm                                               aws:///us-east-2b/i-09dcb479c39b9acf3             4h24m   
huliu-aws509a-59qsm-worker-us-east-2c-47n92   huliu-aws509a-59qsm                                               aws:///us-east-2c/i-039e58af6496362e4             4h24m

Actual results:

    the CAPI-authoritative Machine cannot be scale down

Expected results:

    the CAPI-authoritative Machine can be scale down

Additional info:

    slack discusion: https://redhat-internal.slack.com/archives/GE2HQ9QP4/p1746777766970039
must-gather: https://drive.google.com/file/d/1umkuGvdQZKJsFYdzLdseUJY_Z1gNRwvE/view?usp=sharing

blocks

OCPBUGS-56055 When .spec.authoritativeAPI: MachineAPI and spec.template.spec.authoritativeAPI: ClusterAPI , the CAPI-authoritative Machine cannot be scale down

Closed

is cloned by

OCPBUGS-56055 When .spec.authoritativeAPI: MachineAPI and spec.template.spec.authoritativeAPI: ClusterAPI , the CAPI-authoritative Machine cannot be scale down

Closed

links to

openshift/cluster-capi-operator#290: OCPBUGS-55985: fix: machine: propagate non-authoritative deletion

Assignee:: Damiano Donati

Reporter:: Huali Liu

Need Info From:: None

Contributors:: None

QA Contact:: Huali Liu

Doc Contact:: None

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 2025/05/09 8:48 AM

Updated:: 2025/10/21 4:26 AM

Resolved:: 2025/10/21 4:26 AM

Details

Description

Attachments

Issue Links

Easy Agile Planning Poker

Activity

People

Dates

Hide