-
Bug
-
Resolution: Unresolved
-
Undefined
-
4.19
-
None
-
Quality / Stability / Reliability
-
False
-
-
None
-
Moderate
-
None
-
None
-
None
-
None
-
Proposed
-
None
-
-
None
-
None
-
None
-
None
Description of problem:
When user configure custom masthead logo for a theme, but leave the rest theme as default, it doesn't show default OpenShift masthead logo for the rest theme.
Version-Release number of selected component (if applicable):
https://github.com/openshift/console/pull/14749/
How reproducible:
Always
Steps to Reproduce:
1.Config custom masthead logo for a theme, leave the rest as default. For example, configure a custom masthead logo for dark theme. {code:java} $ oc get consoles.operator.openshift.io cluster -o json --kubeconfig 14749.kubeconfig | jq '.spec.customization.logos' [ { "themes": [ { "mode": "Dark", "source": { "configMap": { "key": "masthead-dark-logo.png", "name": "custom-logo-masthead-dark" }, "from": "ConfigMap" } } ], "type": "Masthead" } ]
2. After console pod is restarted. Check masthead logo.
3.
Actual results:{code:none} 2. The custom logo shows up for masthead and also shows up on about page when console is in dark theme. It's empty for masthead when console is in light theme, but default logo shows up on about page. screenshot: https://drive.google.com/file/d/1SMiO38XpNveEGG6CvbHzUXKfDzAP85fs/view?usp=drive_link
Expected results:
2. Should show default OpenShift logo for masthead when console is in light theme.
Additional info:
Guess code in https://github.com/openshift/console/pull/14749/files#diff-405eb65f788e5a0d149321eec7b359f9e6c22a54c1fd7f1973b2bc6d508f599cR71 needs update, the judgement for 'loading' is not required.
- blocks
-
OCPBUGS-57054 Should show default OpenShift Logo for a theme when there is not custom logo set for the theme.
-
- Closed
-
- is cloned by
-
OCPBUGS-57054 Should show default OpenShift Logo for a theme when there is not custom logo set for the theme.
-
- Closed
-
- links to