With trigger annotations set from the web console in recent OCP versions, new images pushed to an image stream do not result in an update of the image properties in related deployment resources.

This issue was originally reported by users on an OCP cluster running version 4.14.48, and could be tracked down to the console setting the value for the "paused" key in the annotation as "false" (including the quotes). The behavior could be fixed by changing the value to a plain false (without the quotes).

Further investigation revealed this to be a regression introduced with 4.14.46 as part of the bugfix for OCPBUGS-33145, a backport of OCPBUGS-26073 (fixed in 4.16.0) and OCPBUGS-32506 (fixed in 4.15.13). This change intended to fix an earlier error where "paused" was misspelled as "pause" by the console, and the corresponding value therefore always got ignored by the image trigger controller of the openshift-controller-manager: It was not possible to pause the trigger from the web console.

However, apparently it was missed that in the old code not only the key, but also its value were incorrect: They were quoted as string values "true" and "false", whereas the corresponding field Paused in the ObjectFieldTrigger type is a bool, and the conversion is done by Golang's standard JSON unmarshaller, which evaluates all non-empty strings to true. Hence, the bugfix for OCPBUGS-26073 introduces the opposite bug: It's no longer possible to unpause a trigger from the web console.

This error got fixed in git with https://github.com/openshift/console/commit/1824081f07bb835d4627e4577c3d33e7cbb1c0aa, apparently a direct commit without any reference to a PR or bug report. Therefore, its relation as a bugfix to the original commit, and the corresponding regression went unnoticed so far, it seems. The commit got included in OCP 4.18 when it was branched off, but it never got backported to any of the earlier releases. This means that the following versions should be affected by this bug:

* OCP 4.14.46 and later (tested with 4.14.48)
* OCP 4.15.13 and later (not tested, but based on code inspection)
* OCP 4.16, all released versions (not tested, but based on code inspection)
* OCP 4.17, all released versions (not tested, but based on code inspection)

A backport of https://github.com/openshift/console/commit/1824081f07bb835d4627e4577c3d33e7cbb1c0aa should suffice as a fix for all of these.

Always when pausing or unpausing image triggers from the web console

Similar to OCPBUGS-26073:
In Form view of Deployment with the web console, in Images section -> "Enable Deploy image from an image stream tag", check or uncheck "Enable Auto deploy when new Image is available an save the changes", and inspect the value for "paused" in the image.openshift.io/triggers annotation. Also, push updates to configured image stream tag, and verify that image property in the deployment does not get updated.

Pushing updates to an image stream tag do not result in an update of the image propery, even though a respective trigger was enabled in the web console for a deployment.   

Image property gets updated when new images are pushed to image stream tag if trigger is enabled from the web console.    

Upstream commit with bugfix: https://github.com/openshift/console/commit/1824081f07bb835d4627e4577c3d33e7cbb1c0aa