Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-54777

oc adm node-image panics in case of error

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • 4.18.z, 4.19.0
    • oc / node-image
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • Moderate
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      When running the oc adm node-image create command, in case of error the tool returns a panic    

      Version-Release number of selected component (if applicable):

       4.19, 4.18   

      How reproducible:

      Execute oc adm node-image create command with some wrong param, for example by not having the nodes-config.yaml or by not specifying a kubeconfig

      Steps to Reproduce:

          1.
          2.
          3.
          

      Actual results:

       A stack trace is printed in the console output   

      Expected results:

          The exact reason of the error should be reported

      Additional info:

          It looks like a typo added in commit 0601c2e, this line https://github.com/openshift/oc/blob/1719de833ae8e8a272ff55ca2a80489e6c791d92/pkg/cli/admin/nodeimage/create.go#L180 should return the error instead of nil

              ppinjark@redhat.com pawan pinjarkar
              afasano@redhat.com Andrea Fasano
              None
              None
              zhenying niu zhenying niu
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: