Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-54592

PIS reference in MCN status reports `LastFailedGeneration` even when no error has occurred

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • 1
    • Low
    • None
    • None
    • MCO Sprint 269, MCO Sprint 270
    • 2
    • In Progress
    • Release Note Not Required
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      When a valid PinnedImageSet is applied, the PinnedImageSets reference in the MCN’s status displays a default `LastFailedGeneration` value of 0.

      Version-Release number of selected component (if applicable):

      4.19.0-0.nightly-arm64-2025-03-21-080021

      How reproducible:

      Always.

      Steps to Reproduce:

      1. Apply a valid PIS.

      apiVersion: machineconfiguration.openshift.io/v1alpha1
      kind: PinnedImageSet
      metadata:
        name: test-pinned
        labels:
          machineconfiguration.openshift.io/role: "worker"
      spec:
        pinnedImages:
         - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
         - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

      2. Wait for the PIS application to complete and view the MCN for a targeted node.

      $ oc describe machineconfignode/<node-name>
      …
      Status:
        Conditions:
          Last Transition Time:  2025-04-03T13:04:57Z
          Message:               All pinned image sets complete
          Reason:                AsExpected
          Status:                False
          Type:                  PinnedImageSetsProgressing
      …
          Last Transition Time:  2025-04-03T13:04:57Z
          Message:               All is good
          Reason:                AsExpected
          Status:                False
          Type:                  PinnedImageSetsDegraded
      …
        Pinned Image Sets:
          Current Generation:      1
          Desired Generation:      1
          Last Failed Generation:  0
          Name:                    test-pinned 

      Actual results:

      The PinnedImageSets reference contains a value for LastFailedGeneration.

      Expected results:

      Since no error has occurred, no LastFailedGeneration should be populated.

      Additional info:

      If testing in a cluster with an api version later than API PR #2201’s merge, both the `LastFailedGeneration` and `LastFailedGenerationError` fields are populated with default values on a successful PIS application. Example:

      Status:
        Pinned Image Sets:
          Current Generation:            1
          Desired Generation:            1
          Last Failed Generation:        0
          Last Failed Generation Error: 
          Name:                          test-pinned

              rh-ee-ijanssen Isabella Janssen
              rh-ee-ijanssen Isabella Janssen
              None
              None
              Sergio Regidor de la Rosa Sergio Regidor de la Rosa
              None
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: