-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.19.0
-
Quality / Stability / Reliability
-
False
-
-
None
-
Low
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
Description of problem:
When a PinnedImageSets is applied, its status is reflected in the MCN conditions `PinnedImageSetsProgressing` and `PinnedImageSetsDegraded`. The MCN enhancement states that once an update is complete, the condition reason and message should show that they are from a previous update cycle. PIS conditions do not follow this pattern.
Version-Release number of selected component (if applicable):
Found in 4.19, but likely in all versions with PIS in tech preview. Backporting this fix is likely unnecessary.
How reproducible:
Always.
Steps to Reproduce:
1. Apply a PIS, such as the following.
apiVersion: machineconfiguration.openshift.io/v1alpha1
kind: PinnedImageSet
metadata:
name: test-pinned
labels:
machineconfiguration.openshift.io/role: "worker"
spec:
pinnedImages:
- name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
2. Wait for the PIS application to complete and view the MCN for a targeted node.
… Status: Conditions: Last Transition Time: 2025-04-01T15:18:49Z Message: All pinned image sets complete Reason: AsExpected Status: False Type: PinnedImageSetsProgressing … Last Transition Time: 2025-04-01T15:18:49Z Message: All is good Reason: AsExpected Status: False Type: PinnedImageSetsDegraded …
Actual results:
The PIS conditions do not indicate they are from a previous update once the application is complete.
Expected results:
The PIS conditions should indicate they are from a previous update once the application is complete. An example of a condition from a standard update reporting in the intended fashion is: ``` Last Transition Time: 2025-03-27T13:12:12Z Message: Action during update to rendered-worker-45ac14b45fcce5e8ff6d83954921b2d2: UnCordoned node. The node is reporting Unschedulable = false Reason: UpdateCompleteUncordoned Status: False Type: Uncordoned ```
Additional info:
