Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-54348

TALM Soak Annotation evaluates single "FirstCompliantAt" per CGU instead of per Policy

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Major Major
    • None
    • 4.16.z
    • TALM Operator
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • Important
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

      In a given CGU A, that contains several policies that make use of the soak-seconds annotation, the timestamp to start counting 'soak' time (once the current Policy is Compliant), named clusterGroupUpgrade.Status.Status.CurrentBatchRemediationProgress[clusterName].FirstCompliantAt, is only overwritten once per CGU.
      In the shouldSoak() function, the timestamp to evaluate whether the CGU should soak or not should be per Policy, for example, saved together with currentManagedPolicyInfo := clusterGroupUpgrade.Status.ManagedPoliciesForUpgrade[currentPolicyIndex]

      Version-Release number of selected component (if applicable):

          4.16

      How reproducible:

      100%, just using the soak-seconds annotation once    

      Steps to Reproduce:

          1. Create a CGU with several Policies, one of them with soak-annotation in place
          2. Check controller logs: All 'FirstCompliantAt' from the following policies, that never were compliant, instead of showing null (green screenshot attached) show the time of the first soak timestamp (red screenshot attached)
          

      Actual results:

          Soak counter is working once; after single use, it becomes useless.

      Expected results:

          Soak counter should work at any Policy. 
          No matter how many policies require soak time, for grace period purposes, all of them should include the counter

       

       

       

              saskari@redhat.com Saeid Askari
              tginer@redhat.com Teresa Giner Ruiz
              None
              None
              Dwaine Gonyier Dwaine Gonyier
              None
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Created:
                Updated:
                Resolved: