Description of problem:

The TestControllerEventuallyReconciles within the e2e-gcp-op-ocl test suite fails very often, which prevents the rest of the job from running. This causes reduced confidence in the test suite and lowers the overall quality signal for OCL.

Version-Release number of selected component (if applicable):

N/A

How reproducible:

Often.

Steps to Reproduce:

Run the e2e-gcp-op-ocl job by opening a PR. The job will eventually fail on this test.

Actual results:

The test, TestControllerEventuallyReconciles fails on a fairly consistent basis.

Expected results:

The test should pass.

Additional info:

I suspect that part of the problem is that the "success" criteria between the Build Controller and the e2e test suite are not the same. As part of the potential fix I've found, I exported the success criteria function so that it can be reused with the e2e test suite and I've also set certain hard-coded values as constants instead so that they can be adjusted from one central place.