Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-53444

when the value is not explicit set by user in the SriovOperatorConfig object it does not set to true for enableInjector and enableOperatorWebhook in SriovOperatorConfig.spec.

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 4.19
    • 4.13.z, 4.12.z, 4.14.z, 4.15.z, 4.17.z, 4.16.z, 4.18.z
    • None
    • Important
    • None
    • 3
    • OSDOCS Sprint 268, OSDOCS Sprint 269
    • 2
    • False
    • Hide

      None

      Show
      None
    • N/A
    • Release Note Not Required
    • Done

      Description of problem:

      Description of the below performed tests to identify the default values for the parameters in SriovOperatorConfig.spec. and what attributes we get from the command : [$  oc -n openshift-sriov-network-operator get SriovOperatorConfig -o custom-columns='Name:.metadata.name,Injector:.spec.enableInjector,OperatorWebhook:spec.enableOperatorWebhook']

      Version-Release number of selected component (if applicable):

          4.18

      How reproducible:

          Easily

      Steps to Reproduce:

      Skipping the parameters enableInjector and enableOperatorWebhook in SriovOperatorConfig.spec. at the time of creating CR. 
      
      ~~~
      [root@vm-236-142 ~]# cat <<EOF | oc create -f -
      apiVersion: sriovnetwork.openshift.io/v1
      kind: SriovOperatorConfig
      metadata:
        name: default
        namespace: openshift-sriov-network-operator
      spec:
        logLevel: 2  disableDrain: 
      
      falseEOFsriovoperatorconfig.sriovnetwork.openshift.io/default created
      ~~~
      
      
      

       

      Actual results:

      Default value seems to be set to false. The Documentation says "By default, this field is set to true." However in practice the default value is false which gives <none> output; unless we specify explicitly to be true. 
      
      ~~~
      [root@vm-236-142 ~]# oc -n openshift-sriov-network-operator get SriovOperatorConfig -o custom-columns='Name:.metadata.name,Injector:.spec.enableInjector,OperatorWebhook:spec.enableOperatorWebhook'
      
      Name      Injector   OperatorWebhook
      default   <none>     <none>           <<<
      ~~~

      Expected results:

      [root@vm-236-142 ~]# oc -n openshift-sriov-network-operator get SriovOperatorConfig -o custom-columns='Name:.metadata.name,Injector:.spec.enableInjector,OperatorWebhook:spec.enableOperatorWebhook'
      
      Name      Injector   OperatorWebhook
      default   true      true           <<<

      Additional info:

       As per the documentation [https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/networking/networking-operators#nw-sriov-operator-cr_configuring-sriov-operator] By default, this field is set to true.

              dfitzmau@redhat.com Darragh Fitzmaurice
              rhn-support-zekhan Zeba Khan
              Zhanqi Zhao Zhanqi Zhao
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: