Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-53106

Adding a node with `oc adm node-image` fails for disconnected environment

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • 4.19.0
    • 4.17
    • oc / node-image
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • Agent Sprint 269, Agent Sprint 270
    • 2
    • Done
    • Bug Fix
    • Hide
      * Previously, if you tried to add a node to a disconnected environment using the `oc adm node-image` command, private registry images were inaccessible to the command, causing node addition failure. This error only occurred if the cluster was initially installed with an installer binary downloaded from (link:https://mirror.openshift.com/pub/)[mirror.openshift.com]. With this release, a fix has been implemented that enables successful image pull and node creation in disconnected environments. (link:https://issues.redhat.com/browse/OCPBUGS-53106[OCPBUGS-53106])
      Show
      * Previously, if you tried to add a node to a disconnected environment using the `oc adm node-image` command, private registry images were inaccessible to the command, causing node addition failure. This error only occurred if the cluster was initially installed with an installer binary downloaded from (link: https://mirror.openshift.com/pub/) [mirror.openshift.com]. With this release, a fix has been implemented that enables successful image pull and node creation in disconnected environments. (link: https://issues.redhat.com/browse/OCPBUGS-53106 [ OCPBUGS-53106 ])
    • None
    • None
    • None
    • None

      Description of problem:

          Adding a node with `oc adm node-image` is unable to pull the release image container and fails to generate the new node ISO.

      Version-Release number of selected component (if applicable):

          

      How reproducible:

          100%

      Steps to Reproduce:

          1. Deploy OpenShift cluster with private registry in an offline environment
          2. Create the nodes-config.yaml for new nodes
          3. Run "oc adm node-image create --dir=/tmp/assets
          

      Actual results:

          Command fails with error saying that it cannot pull from quay.io/openshift-release-dev/ocp-release@shaXXXXX

      Expected results:

          Command generates an ISO used to add the new worker nodes

      Additional info:

          When creating the initial agent ISO using "openshift-install agent create image" command, we can see in the output that a sub command is run, "oc adm release extract". When the install-config.yaml contains the ImageContentSourcePolicy section, or ImageDigestMirrorSet section, a flag is added to "oc adm release extract --icsp or idms" which contains the mappings from quay.io to the private registry.
      
          The oc command does not have a top level icsp or idms flag. The oc adm node-image command needs to have a flag for icsp or idms such that it is able to understand that instead of pulling the release image from quay.io it should pull the image from the private registry.
      
          Without this flag, the oc command has no way to know that it should be pulling container images from a private registry.

              bfournie@redhat.com Robert Fournier
              dan5179 Dan Clark
              None
              None
              Manoj Hans Manoj Hans
              None
              Votes:
              3 Vote for this issue
              Watchers:
              23 Start watching this issue

                Created:
                Updated:
                Resolved: