Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-53052

Rebase script for openshift/ocp-release-operator-sdk should create a separate drop commit for the vendor directory

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • None
    • 4.19.0
    • Operator SDK
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • Rejected
    • None
    • Done
    • Release Note Not Required
    • N/A
    • None
    • None
    • None
    • None

      Description of problem:

      Currently the rebase script for openshift/ocp-release-operator-sdk adds the updated vendor directory to the merge commit

      Version-Release number of selected component (if applicable):

      How reproducible:

      When the rebase is done using the script and when there's no need for a go mod tidy before running go mod vendor, the vendor directory is updated and added to the merge commit. For example: https://github.com/openshift/ocp-release-operator-sdk/pull/424/commits/abd5b39aa51c4e46b3be8a89f1b0c03461350502    

      Steps to Reproduce:

          1.
    2.
    3.

      Actual results:

      Rebase script for openshift/ocp-release-operator-sdk adds the updated vendor directory to the merge commit  

      Expected results:

      Rebase script for openshift/ocp-release-operator-sdk creates a separate drop commit for the vendor directory  

      Additional info:

              rh-ee-arsen Arkadeep Sen (Aurko)
              rh-ee-arsen Arkadeep Sen (Aurko)
              None
              None
              Jia Fan Jia Fan
              None
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: