Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-52504

'oc adm upgrade recommend' should not panic on precheck Route lookup

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.19
    • oc / update

      Description of problem

      The precheck functionality introduced by OTA-1426 flubbed the Route lookup implementation, and crashes with a seg-fault. Thanks to rh-ee-bpearson for reporting.

      Version-Release number of selected component

      4.19 code behind both the OC_ENABLE_CMD_UPGRADE_RECOMMEND=true and OC_ENABLE_CMD_UPGRADE_RECOMMEND_PRECHECK=true feature gates.

      How reproducible

      Every time.

      Steps to Reproduce

      $ export OC_ENABLE_CMD_UPGRADE_RECOMMEND=true  # overall 'recommend' command still tech-preview
      $ export OC_ENABLE_CMD_UPGRADE_RECOMMEND_PRECHECK=true  # pre-check functionality even more tech-preview
      $ ./oc adm upgrade recommend
      

      Actual results

      panic: runtime error: invalid memory address or nil pointer dereference
      [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x3bd3cdd]
      
      goroutine 1 [running]:
      github.com/openshift/client-go/route/clientset/versioned/typed/route/v1.NewForConfig(0x24ec35c?)
      	/go/src/github.com/openshift/oc/vendor/github.com/openshift/client-go/route/clientset/versioned/typed/route/v1/route_client.go:31 +0x1d
      github.com/openshift/oc/pkg/cli/admin/upgrade/recommend.(*options).alerts(0xc000663130, {0x5ed4828, 0x8350a80})
      	/go/src/github.com/openshift/oc/pkg/cli/admin/upgrade/recommend/alerts.go:34 +0x170
      github.com/openshift/oc/pkg/cli/admin/upgrade/recommend.(*options).precheck(0x0?, {0x5ed4828, 0x8350a80})
      ...
      

      Expected results

      Successful precheck execution and reporting.

              trking W. Trevor King
              trking W. Trevor King
              Jian Li Jian Li
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: