Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-51375

registryOverrides not used in getCatalogImages

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Critical Critical
    • None
    • 4.19.0
    • HyperShift
    • None
    • Proposed
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, you could not use the `registryOverride` option to override catalog Operator images. With this release, the logic for the control plane Operator is updated and the issue is resolved. (link:https://issues.redhat.com/browse/OCPBUGS-51375[*OCPBUGS-51375*])
      -----
      *Cause*: User setting the registryOverride for catalog images doesn't take effect.
      *Consequence*: prevents cluster operators coming up when the registry.redhat.io/redhat registry is being overriden
      *Workaround*: use linked annotations to directly override the catalog images directly. link https://github.com/openshift/hypershift/blob/18ffc1b3c0605ff9e636ad7ecfa5d793cb22ae72/vendor/github.com/openshift/hypershift/api/hypershift/v1beta1/hostedcluster_types.go#L92-L95

      *Result*: Fix for this has been included in 4.18.4
      Show
      * Previously, you could not use the `registryOverride` option to override catalog Operator images. With this release, the logic for the control plane Operator is updated and the issue is resolved. (link: https://issues.redhat.com/browse/OCPBUGS-51375 [* OCPBUGS-51375 *]) ----- *Cause*: User setting the registryOverride for catalog images doesn't take effect. *Consequence*: prevents cluster operators coming up when the registry.redhat.io/redhat registry is being overriden *Workaround*: use linked annotations to directly override the catalog images directly. link https://github.com/openshift/hypershift/blob/18ffc1b3c0605ff9e636ad7ecfa5d793cb22ae72/vendor/github.com/openshift/hypershift/api/hypershift/v1beta1/hostedcluster_types.go#L92-L95 *Result*: Fix for this has been included in 4.18.4
    • Known Issue
    • Done

      This is a clone of issue OCPBUGS-49825. The following is the description of the original issue:
      —
      Description of problem:

          https://github.com/openshift/hypershift/blob/5d03cfa7e250e06cf408fd0b6c46d207ab915c1e/control-plane-operator/controllers/hostedcontrolplane/olm/catalogs.go#L126 We should check registry overrides here and retrive the images from the mirrored registry

We currently dont check this which means it could prevent the cluster operators coming up if the registry.redhat.io/redhat registry is being overriden. 
      In addition to the above the releaseImageProvider we use in the HCCO and HCP rencociler doesnt use the registry overrides set at the HO level which could cause confusions for users that expect those overrides to be propagated to the HCP.

      Version-Release number of selected component (if applicable):

          4.19

      How reproducible:

          100%

      Steps to Reproduce:

          1. Set Registry override for registry.redhat.io/redhat 
    2. Notice catalog operatores still using registry.redhat.io/redhat images 
    3.

      Actual results:

          catalog operators using registry.redhat.io/redhat images

      Expected results:

          catalog operators use override set at HO level or set through OLM override flag on HC

      Additional info:

              pstefans@redhat.com Patryk Stefanski
              openshift-crt-jira-prow OpenShift Prow Bot
              XiuJuan Wang XiuJuan Wang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: