Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-50915

hcp capi machineset fail machineset preflight

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • 4.19.0
    • HyperShift
    • None
    • None
    • False
    • Hide

      None

      Show
      None

      This enabled machineset preflights by default https://github.com/kubernetes-sigs/cluster-api/pull/11228

      We won't to disable this functionality in hcp because of the following reasons:

      • MachineSetPreflightCheckControlPlaneIsStable
        We currently don't express intent for a version via spec.version but via spec.release
      • MachineSetPreflightCheckKubernetesVersionSkew
        We preserve our ability to control our skew policy at a higher layer i.e. NodePool API

      MachineSetPreflightCheckKubeadmVersionSkew

      • We don't run kubeadmin at all.

            [OCPBUGS-50915] hcp capi machineset fail machineset preflight

            Wen Wang added a comment - - edited

            Verified in hypershift version:
            quay.io/hypershift/hypershift-operator@sha256:b91f56a835f00e7094a1e71dab05d2e91b1417b7673669ab85effb2e5a8afff8

            [wewang@wewang-thinkpadt14sgen2i ~]$ oc  get machineset -n clusters-hypershift-ci-340662 -oyaml |grep   -A 7  annotations |grep machineset.cluster.x-k8s.io/skip-preflight-checks
                  machineset.cluster.x-k8s.io/skip-preflight-checks: All
                  machineset.cluster.x-k8s.io/skip-preflight-checks: All
                  machineset.cluster.x-k8s.io/skip-preflight-checks: All
            [wewang@wewang-thinkpadt14sgen2i ~]$ oc  get machinedeployment -n clusters-hypershift-ci-340662 -oyaml |grep   -A 6  annotations |grep machineset.cluster.x-k8s.io/skip-preflight-checks
                  machineset.cluster.x-k8s.io/skip-preflight-checks: All
                  machineset.cluster.x-k8s.io/skip-preflight-checks: All
                  machineset.cluster.x-k8s.io/skip-preflight-checks: All
            
            $ oc get deployment/capi-controller-manager -ojsonpath='{.spec.template.spec.containers[0]}' -n openshift-cluster-api  | jq .
            {
              "args": [
                "--leader-elect",
                "--diagnostics-address=:8443",
                "--insecure-diagnostics=false",
                "--use-deprecated-infra-machine-naming=false",
                "--feature-gates=MachinePool=true,ClusterResourceSet=true,ClusterTopology=false,RuntimeSDK=false,MachineSetPreflightChecks=false",
            

            Wen Wang added a comment - - edited Verified in hypershift version: quay.io/hypershift/hypershift-operator@sha256:b91f56a835f00e7094a1e71dab05d2e91b1417b7673669ab85effb2e5a8afff8 [wewang@wewang-thinkpadt14sgen2i ~]$ oc get machineset -n clusters-hypershift-ci-340662 -oyaml |grep -A 7 annotations |grep machineset.cluster.x-k8s.io/skip-preflight-checks machineset.cluster.x-k8s.io/skip-preflight-checks: All machineset.cluster.x-k8s.io/skip-preflight-checks: All machineset.cluster.x-k8s.io/skip-preflight-checks: All [wewang@wewang-thinkpadt14sgen2i ~]$ oc get machinedeployment -n clusters-hypershift-ci-340662 -oyaml |grep -A 6 annotations |grep machineset.cluster.x-k8s.io/skip-preflight-checks machineset.cluster.x-k8s.io/skip-preflight-checks: All machineset.cluster.x-k8s.io/skip-preflight-checks: All machineset.cluster.x-k8s.io/skip-preflight-checks: All $ oc get deployment/capi-controller-manager -ojsonpath= '{.spec.template.spec.containers[0]}' -n openshift-cluster-api | jq . { "args" : [ "--leader-elect" , "--diagnostics-address=:8443" , "--insecure-diagnostics= false " , "--use-deprecated-infra-machine-naming= false " , "--feature-gates=MachinePool= true ,ClusterResourceSet= true ,ClusterTopology= false ,RuntimeSDK= false ,MachineSetPreflightChecks= false " ,

            Hi agarcial@redhat.com,

            Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            OpenShift Jira Bot added a comment - Hi agarcial@redhat.com , Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            Wen Wang added a comment -

            Build a hyperhsift binary with version:
            hypershift version openshift/hypershift: b5cdebc8681d5396ff42e83fc638772b4dca3218)
            1. Tested capi deployment, now MachineSetPreflightChecks=false is added in containers args:

            root@wewang-thinkpadt14sgen2i ~]# oc get deployment/capi-controller-manager -ojsonpath='{.spec.template.spec.containers[0].args}' -n openshift-cluster-api
            ["--leader-elect","--diagnostics-address=:8443","--insecure-diagnostics=false","--use-deprecated-infra-machine-naming=false","--feature-gates=MachinePool=true,ClusterResourceSet=true,ClusterTopology=false,RuntimeSDK=false,MachineSetPreflightChecks=false"]
            

            2. But machinedeployment has no annotation for machineset.cluster.x-k8s.io/skip-preflight-checks: All, will check it tommorrow.

            Wen Wang added a comment - Build a hyperhsift binary with version: hypershift version openshift/hypershift: b5cdebc8681d5396ff42e83fc638772b4dca3218) 1. Tested capi deployment, now MachineSetPreflightChecks=false is added in containers args: root@wewang-thinkpadt14sgen2i ~]# oc get deployment/capi-controller-manager -ojsonpath= '{.spec.template.spec.containers[0].args}' -n openshift-cluster-api [ "--leader-elect" , "--diagnostics-address=:8443" , "--insecure-diagnostics= false " , "--use-deprecated-infra-machine-naming= false " , "--feature-gates=MachinePool= true ,ClusterResourceSet= true ,ClusterTopology= false ,RuntimeSDK= false ,MachineSetPreflightChecks= false " ] 2. But machinedeployment has no annotation for machineset.cluster.x-k8s.io/skip-preflight-checks: All, will check it tommorrow.

              agarcial@redhat.com Alberto Garcia Lamela
              agarcial@redhat.com Alberto Garcia Lamela
              Wen Wang Wen Wang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: