Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-502

PtpOperatorConfig set by ZTP for ptpEventConfig prevents SNO expansion with zero downtime

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • 4.12.0
    • GitOps ZTP
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • Important
    • None
    • None
    • Proposed
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      This is a clone of issue OCPBUGS-496. The following is the description of the original issue:

      This is a clone of issue OCPBUGS-217. The following is the description of the original issue:

      Description of problem:

      ZTP DU workflow provisions PtpOperatorConfig resource in case there is a need for ptpEventConfig setting, and for standard clusters regardless of ptp event needs.
      For SNOs, the PtpOperatorConfig resource includes daemonsetNodeSelector set to "master".
      If at a later time SNO is expanded with one or more workers, PTP operator would not create linuxptp-daemon containers on the worker node(s). Any attempt to change the daemonsetNodeSelector will result in ptp daemon restart and time synchronization loss.

      This is a valid behavior described in the operator readme.

      Suggest to provision daemonNodeSelector set to "worker", which should fit all the deployment types known so far (both SNO and 3NC nodes have the "worker" label, and will be selected)

      For the users that already have PtpOperatorConfig deployed with "master" selector, it should be documented that SNO expansion will incur momentary PTP sync loss

      Version-Release number of selected component (if applicable):

      How reproducible:

      Steps to Reproduce:
      1. Add worker node to SNO
      2. Deploy PTP configuration
      3.

      Actual results:

      ptp daemon is not deployed on worker

      Expected results:

      ptp daemon is deployed on worker

      Additional info:
      https://github.com/openshift-kni/cnf-features-deploy/blob/dd1322d7f77d4e4fc56badfd04c9b4d8d7c6e05f/ztp/source-crs/PtpOperatorConfig.yaml#L10
      https://github.com/openshift-kni/cnf-features-deploy/blob/dd1322d7f77d4e4fc56badfd04c9b4d8d7c6e05f/ztp/source-crs/PtpOperatorConfigForEvent.yaml#L10

              vgrinber@redhat.com Vitaly Grinberg
              openshift-crt-jira-prow OpenShift Prow Bot
              None
              None
              Yang Liu Yang Liu
              None
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: