Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-49709

Modals launched with `useModal` overwrite each other

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • 4.20.0
    • 4.16, 4.17, 4.18, 4.19
    • Management Console
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • Yes
    • Proposed
    • Bug Fix
    • Hide
      Before this update, opening a modal on a Networking page caused some web console plugin panels, such as the OpenShift Lightspeed UI or the Troubleshooting panel, to disappear. This update resolves the conflict between networking modals and web console plugins. As a result, modals on Networking pages no longer hide other console panels. (link:https://issues.redhat.com/browse/OCPBUGS-49709[OCPBUGS-49709])
      Show
      Before this update, opening a modal on a Networking page caused some web console plugin panels, such as the OpenShift Lightspeed UI or the Troubleshooting panel, to disappear. This update resolves the conflict between networking modals and web console plugins. As a result, modals on Networking pages no longer hide other console panels. (link: https://issues.redhat.com/browse/OCPBUGS-49709 [ OCPBUGS-49709 ])
    • None
    • None
    • None
    • None

      Description of problem:

      If multiple plugins are using the `useModal` hook, their modals will overwrite each other.
      
      The OpenShift Lightspeed plugin, the OpenShift Console Troubleshooting Panel plugin and the Networking pages all use the `useModal` hook, so they can overwrite each other in the UI.
      
      Regression in 4.17, since the Networking pages seem to have started using the `useModal` hook from 4.17, meaning that the bug is much more likely to be encountered from that version.
      
      Since both the OpenShift Lightspeed plugin and the OpenShift Console Troubleshooting Panel plugin support 4.16, the bug should be seen in 4.16 too.

      Version-Release number of selected component (if applicable):

          

      How reproducible:

          Always

      Steps to Reproduce:

          1. Install the OpenShift Lightspeed operator
          2. Create OLSConfig
          3. Wait until OpenShift Lightspeed is running
          4. Navigate to any page under "Networking" (e.g. Networking > Services)
          5. Trigger any action that causes a modal to be displayed (e.g. select "Edit labels" from one of the list kebab menus)
          6. When the "Edit labels" modal is displayed, the OpenShift Lightspeed UI disappears

      Actual results:

          When a modal on a page under Networking is displayed, the OpenShift Lightspeed UI disappears. Similarly, the OpenShift Console Troubleshooting Panel would disappear if it was open.

      Expected results:

          It should be possible to display all of the OpenShift Lightspeed UI, the OpenShift Console Troubleshooting panel and the Networking page modals at the same time.

      Additional info:

          

              anpicker@redhat.com Andrew Pickering
              anpicker@redhat.com Andrew Pickering
              None
              None
              YaDan Pei YaDan Pei
              Jocelyn Sese Jocelyn Sese
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: