Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-49407

numaresources: use go-cmp only in tests

XMLWordPrintable

    • None
    • CNF Compute Sprint 265, CNF Compute Sprint 266, CNF Compute Sprint 267
    • 3
    • False
    • Hide

      None

      Show
      None

      Description of problem:

          Similarly to https://github.com/kubernetes/kubernetes/issues/104821 , we use the go-cmp package in our non-test code. Problem is: this package reserves the right to panic, which is something we cannot accept in out non-test code. We need to replace to similar code which guarantee not to panic

      Version-Release number of selected component (if applicable):

          since 4.10

      How reproducible:

          cannot reproduce yet. It is however a risk we need to avoid

      Steps to Reproduce:

          1.
          2.
          3.
          

      Actual results:

          comparison code can panic, and we don't know when and why

      Expected results:

          comparison code never panics

      Additional info:

          we should fix only on 4.19 and onwards and backport on 4.18.z. Further backport will be done depending on demand and actual occurrence or not.

              rhn-support-shajmakh Shereen Haj
              fromani@redhat.com Francesco Romani
              Mallapadi Niranjan Mallapadi Niranjan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: