This is a clone of issue OCPBUGS-43432. The following is the description of the original issue:
—
This is a clone of issue OCPBUGS-43383. The following is the description of the original issue:
—
Description of problem:
Running "make fmt" in the repository fails with an error about a version mismatch between goimports and the go language version.
Version-Release number of selected component (if applicable):
4.16
How reproducible:
always
Steps to Reproduce:
1. checkout release-4.16 branch 2. run "make fmt" (with golang version 1.21)
Actual results:
openshift-hack/check-fmt.sh go: downloading golang.org/x/tools v0.26.0 go: golang.org/x/tools/cmd/goimports@latest: golang.org/x/tools@v0.26.0 requires go >= 1.22.0 (running go 1.21.11; GOTOOLCHAIN=local) make: *** [openshift.mk:18: fmt] Error 1
Expected results:
completion without errors
Additional info:
this is affecting us currently with 4.16 and previous, but will become a persistent problem over time. we can correct this by using a holistic approach such as calling goimports from the binary that is included in our build images.
- clones
-
OCPBUGS-43432 Cloud provider vsphere can fail when running goimports through fmt make target
- Closed
- is blocked by
-
OCPBUGS-43432 Cloud provider vsphere can fail when running goimports through fmt make target
- Closed
- links to