Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-46032

MCO ships obsolete storage.conf content drifting from upstream [openshift-4.18]

XMLWordPrintable

    • No
    • Release Note Not Required
    • Done

      Description of problem:

      Machine Config Operator overrides /etc/containers/storage.conf via container-storage.yaml template.  That template is based on a nearly 6 year-old storage.conf file and needs to be reviewed/updated.  Keeping the file up-to-date would have prevented issues such as https://issues.redhat.com/browse/OCPBUGS-42492

      Version-Release number of selected component (if applicable):

      4.14.z -- current

      How reproducible:

      Always

      Steps to Reproduce:

          1.  Install any recent OCP cluster and see /etc/containers/storage.conf file
          

      Actual results:

      The content of /etc/containers/storage.conf is obsolete and does not reflect the current storage options.

      Expected results:

      At a minimum, runroot = "/var/run/containers/storage" needs to be changed to runroot = "/run/containers/storage" or dropped completely, as that is the default on Linux systems.  This was fixed 4 years ago upstream https://github.com/containers/storage/commit/fa5ff265b8b9a736a230ca7f1e718d3bfcf1848b
      
      This option can be dropped completely as "/run/containers/storage" is the runroot default for Linux systems.
      
      As far as I can see, only skip_mount_home needs to be kept explicit
      (MCO commit a3f8a7e4fb99e30da24aa29c230daa9223afed22, OCPNODE-1714)
      
      

       

      Additional info:

      * https://issues.redhat.com/browse/OCPBUGS-42492
      * https://redhat-internal.slack.com/archives/CQNBUEVM2/p1727344491908349

              aos-node@redhat.com Node Team Bot Account
              jmencak Jiri Mencak
              Aditi Sahay Aditi Sahay
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: