Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-45621

The dynamic-system-reserved-calc.sh fails if executed only with `true` parameter

XMLWordPrintable

    • Moderate
    • None
    • False
    • Hide

      None

      Show
      None

      Description of problem:

      Running the `dynamic-system-reserved-calc.sh` script in 4.17 or 4.18 with only `true` parameter fails.
      

       

      Version-Release number of selected component (if applicable):

      4.17, 4.18

       

      How reproducible:

      Always

       

      Steps to Reproduce:

      1. Connect to a 4.17 node (`oc debug` and `chroot /host` or `ssh`)
      2. Run the `dynamic-system-reserved-calc.sh` (set `NODE_SIZES_ENV` to a file in `/tmp/` to not overwrite the env file:
      
      ~~~
      # NODE_SIZES_ENV="/tmp/node-sizing.txt" /usr/local/sbin/dynamic-system-reserved-calc.sh true
      ~~~
      3. It fails with below error:
      ~~~
      /usr/local/sbin/dynamic-system-reserved-calc.sh: line 48: [: : integer expression expected
      ~~~
          

      Actual results:

      The script fails

       

      Expected results:

      The script should create the file with the values in `${NODE_SIZES_ENV}`

       

      Additional info:

      The `dynamic-system-reserved-calc.sh` script changed in 4.17+ by OCPNODE-2211 [1] and OCPNODE-2226 [2].

       

      [1] https://issues.redhat.com/browse/OCPNODE-2211
      [2] https://issues.redhat.com/browse/OCPNODE-2226

              svanka@redhat.com Sai Ramesh Vanka
              oarribas@redhat.com Oscar Arribas Arribas
              Cameron Meadors Cameron Meadors
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: