Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-44505

Remove the crypto-browserify package and use the Crypto object methods instead

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • 4.18, 4.19, 4.20.0
    • Management Console
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      We should remove the crypto-browserify as its only being used in a single place in whole codebase. In addition the only function that we use from this package is a hash generator that is replaceable with functions provided in browser native Crypto API and its digest function. 

       

      Steps to reproduce:

      1. Run console, debug the code of useUserSettings.ts
      2. See that the contents of 'userUid' variable gets initialized as before the changes. 

      Current results:

      1.  Our codebase uses crypto-browserify to generate hashes for usernames in the useUserSettings hook

      Expected results:

      1. We should use the Crypto's 'digest' function instead.
      2. The crypto-browserify package should be removed from the dependencies.

              rh-ee-mziska Marek Ziska (Inactive)
              rh-ee-mziska Marek Ziska (Inactive)
              None
              None
              YaDan Pei YaDan Pei
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: