Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-44477

NTO: nil pointer dereference from external calling of validation method

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • 4.18
    • 4.18
    • Node Tuning Operator
    • None
    • Moderate
    • Yes
    • CNF RAN Sprint 262
    • 1
    • Proposed
    • False
    • Hide

      None

      Show
      None

      The hypershift team has reported a nil pointer dereference causing a crash when attempting to call the validation method on an NTO performance profile.

      This was detected as the hypershift team was attempting to complete a revendoring under OSASINFRA-3643

      Appears to be fallout from https://github.com/openshift/cluster-node-tuning-operator/pull/1086

      Error:

      --- FAIL: TestGetTuningConfig (0.02s)
          --- FAIL: TestGetTuningConfig/gets_a_single_valid_PerformanceProfileConfig (0.00s)
      panic: runtime error: invalid memory address or nil pointer dereference [recovered]
      	panic: runtime error: invalid memory address or nil pointer dereference
      [signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x2ec0fc3]
      
      goroutine 329 [running]:
      testing.tRunner.func1.2({0x31c21e0, 0x651c8c0})
      	/home/emilien/sdk/go1.22.0/src/testing/testing.go:1631 +0x3f7
      testing.tRunner.func1()
      	/home/emilien/sdk/go1.22.0/src/testing/testing.go:1634 +0x6b6
      panic({0x31c21e0?, 0x651c8c0?})
      	/home/emilien/sdk/go1.22.0/src/runtime/panic.go:770 +0x132
      github.com/openshift/cluster-node-tuning-operator/pkg/apis/performanceprofile/v2.(*PerformanceProfile).getNodesList(0xc000fa4000)
      	/home/emilien/git/github.com/shiftstack/hypershift/vendor/github.com/openshift/cluster-node-tuning-operator/pkg/apis/performanceprofile/v2/performanceprofile_validation.go:594 +0x2a3
      github.com/openshift/cluster-node-tuning-operator/pkg/apis/performanceprofile/v2.(*PerformanceProfile).ValidateBasicFields(0xc000fa4000)
      	/home/emilien/git/github.com/shiftstack/hypershift/vendor/github.com/openshift/cluster-node-tuning-operator/pkg/apis/performanceprofile/v2/performanceprofile_validation.go:132 +0x65
      github.com/openshift/hypershift/hypershift-operator/controllers/nodepool.validateTuningConfigManifest({0xc000f34a00, 0x1ee, 0x200})
      	/home/emilien/git/github.com/shiftstack/hypershift/hypershift-operator/controllers/nodepool/nto.go:237 +0x307
      github.com/openshift/hypershift/hypershift-operator/controllers/nodepool.(*NodePoolReconciler).getTuningConfig(0xc000075cd8, {0x50bf5f8, 0x65e4e40}, 0xc000e05408)
      	/home/emilien/git/github.com/shiftstack/hypershift/hypershift-operator/controllers/nodepool/nto.go:187 +0x834
      github.com/openshift/hypershift/hypershift-operator/controllers/nodepool.TestGetTuningConfig.func1(0xc000e07a00)
      	/home/emilien/git/github.com/shiftstack/hypershift/hypershift-operator/controllers/nodepool/nto_test.go:459 +0x297
      testing.tRunner(0xc000e07a00, 0xc000693650)
      	/home/emilien/sdk/go1.22.0/src/testing/testing.go:1689 +0x21f
      created by testing.(*T).Run in goroutine 325
      	/home/emilien/sdk/go1.22.0/src/testing/testing.go:1742 +0x826 

       

              sskeard@redhat.com Steven Skeard
              sskeard@redhat.com Steven Skeard
              Liquan Cui Liquan Cui
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: