The documentation instructions for vSphere IPI advanced network configuration is showing an incorrect step that renders the installation impossible to complete.

It suggests one to delete the machineset manifests. [1] This might be required from an UPI perspective, because otherwise there's an issue with the machineset and machine object being degraded. And this in fact an error that one can not fix.

However, for IPI this does not make any sense. It is a bug, and if someone actually deletes these manifests, the installer will break with the following error:

FATAL failed to fetch Cluster Infrastructure Variables: failed to generate asset "Cluster Infrastructure Variables": master slice cannot be empty
make: *** [makefile:69: start-install] Error 1

[1] https://docs.openshift.com/container-platform/4.16/installing/installing_vsphere/ipi/installing-vsphere-installer-provisioned-network-customizations.html#modifying-nwoperator-config-startup_installing-vsphere-installer-provisioned-network-customizations

    4.16

    All the time, if the documentation is strictly followed

    1. Write up the installation manifests for vsphere IPI
    2. Write extra steps for advanced network configuration (like IPSec, and etcetera)
    3. Remove the machineset manifests as instructed
    4. See that the installation fails to generate the assets
    

    FATAL failed to fetch Cluster Infrastructure Variables: failed to generate asset "Cluster Infrastructure Variables": master slice cannot be empty
make: *** [makefile:69: start-install] Error 1

    The cluster to be provisioned succesfully.