Description of problem:

When defining Environment Variables via the Subscription config[1], deleting the Subscription will remove the Environment Variables from the Deployments, leaving behind a broken Deployment.

Restoring the Subscription won't restore the Environment Variables on the deployments until the CSV is manually removed so OLM will recreate the CSV, which will create Deployments again, this time with the Environment Variables restored.

[1]- https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md#env

Version-Release number of selected component (if applicable):

Potencially all versions, tested on 4.11.

How reproducible:

100%

Steps to Reproduce:
1. Create a Subscription containing .spec.config.env key/values.
2. Observe the Deployment come up with the Env. Vars injected.
3. Delete the Subscription.
4. Observe the Deployment now broken, withouth the Env. Vars defined in the Subscription.
5. Restore the Subscription.
6. Observe the Deployment still broken, not containing the Env Vars from the Subscription.

Actual results:

Subscription deletion removes Environment Variables from Deployments (potencially other Subscription Config settings), leaving the Deployment broken; restoring the Subscription won't restore the environment variables, unless a full CSV cleanup happens.

Expected results:

Deployment is never left in a broken state. We either not touch it on subscription removal or restore it when the Subscription comes back.

I'd assume that, given the OLM design decisions, the expected behaviour here would be not to remove the Env Vars on Subscription deletion.

Additional info:

Upstream report: https://github.com/operator-framework/operator-lifecycle-manager/issues/2840