Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-42324

MachineConfigs should not have Restart=on-failure for oneshot systemd units

XMLWordPrintable

    • Important
    • None
    • MCO Sprint 260
    • 1
    • False
    • Hide

      None

      Show
      None
    • Hide
      A change to RHEL-CoreOS templates shipped by the MCO can cause some node scaling to fail on OpenStack due to systemd, if the original cluster was installed in 4.12 or before, and is still using an old bootimage. This patch fixes node scaling failures due to that.
      Show
      A change to RHEL-CoreOS templates shipped by the MCO can cause some node scaling to fail on OpenStack due to systemd, if the original cluster was installed in 4.12 or before, and is still using an old bootimage. This patch fixes node scaling failures due to that.
    • Bug Fix
    • In Progress

      Description of problem:

      This is a spinoff of https://issues.redhat.com/browse/OCPBUGS-38012. For additional context please see that bug.

The TLDR is that Restart=on-failure for oneshot units were only supported in systemd v244 and onwards, meaning any bootimage for 4.12 and previous doesn't support this on firstboot, and upgraded clusters would no longer be able to scale nodes if it references any such service.

Right now this is only https://github.com/openshift/machine-config-operator/blob/master/templates/common/openstack/units/afterburn-hostname.service.yaml#L16-L24 which isn't covered by https://issues.redhat.com/browse/OCPBUGS-38012

      Version-Release number of selected component (if applicable):

      4.16 right now

      How reproducible:

      Uncertain, but https://issues.redhat.com/browse/OCPBUGS-38012 is 100%

      Steps to Reproduce:

          1.install old openstack cluster
    2.upgrade to 4.16
    3.attempt to scale node

      Actual results:

      Expected results:

      Additional info:

            jerzhang@redhat.com Yu Qi Zhang
            jerzhang@redhat.com Yu Qi Zhang
            Sergio Regidor de la Rosa Sergio Regidor de la Rosa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: