Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-41995

Fixing empty tuned submodule when using Dockerfile

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • 4.18.0
    • Node Tuning Operator
    • None
    • None
    • False
    • Hide

      None

      Show
      None

      Description of problem:
       Since we are using a multi stage builds in the Dockerfile (2 builds), and we need to use the tuned submodule also in the second layer, we must ensure we copy the directory from the builder image (where we initialize the tuned submodule), to the final image.This PR eliminates building errors using the make local-image target like we had before:

      + cd /root/assets/tuned/tuned
      + LC_COLLATE=C
      + cat ../patches/030-no-bootloader-errors.diff
      + patch -Np1
      can't find file to patch at input line 10
      Perhaps you used the wrong -p or --strip option?
      The text leading up to this was:
      --------------------------
      |NTO currently supports the bootloader plugin only on RHCOS via the integration
      |with MCO.  Disable patching of BLS entries and grub configuration files so
      |that error messages from the tuned daemon are eliminated and not reported
      |further on in k8s objects.
      |
      |diff --git a/assets/tuned/daemon/tuned/plugins/plugin_bootloader.py b/assets/tuned/daemon/tuned/plugins/plugin_bootloader.py
      |index 416df7d6..b0a61905 100644
      |--- a/tuned/plugins/plugin_bootloader.py
      |+++ b/tuned/plugins/plugin_bootloader.py
      --------------------------
      File to patch: 
      Skip this patch? [y] 
      Skipping patch.
      3 out of 3 hunks ignored
      Error: building at STEP "RUN /bin/bash /tmp/dockerfile_install_support.sh": while running runtime: exit status 1
      make: *** [Makefile:175: local-image] Error 1

              rh-ee-rbaturov Ronny Baturov
              rh-ee-rbaturov Ronny Baturov
              Liquan Cui Liquan Cui
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: