Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-41726

OLMv1 - [CRD Upgrade Safety] Message output use the human readable value instead of exact bytes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • 4.17
    • OLM
    • Moderate
    • None
    • Rejected
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously when {olmv1-first} validated custom resource definition (CRD) upgrades, the message output when detecting changed default values was rendered in bytes instead of human-readable language. With this update, related messages are now updated to show human-readable values. (link:https://issues.redhat.com/browse/OCPBUGS-41726[*OCPBUGS-41726*])
      Show
      * Previously when {olmv1-first} validated custom resource definition (CRD) upgrades, the message output when detecting changed default values was rendered in bytes instead of human-readable language. With this update, related messages are now updated to show human-readable values. (link: https://issues.redhat.com/browse/OCPBUGS-41726 [* OCPBUGS-41726 *])
    • Bug Fix
    • Done

      Description of problem:

      When upgrading a CRD,
      A new default value is added to a field that did not previously have a default value
      The default value of a field is changed
      An existing default value of a field is removed

      This looks like it is behaving properly but the exact message output seems pretty unhelpful since it seems to be giving the exact bytes instead of a human readable value.
      we get an output similar to:

      message: 'validating upgrade for CRD "nginxolm75124s.cache.example.com" failed:
      CustomResourceDefinition nginxolm75124s.cache.example.com failed upgrade safety
      validation. "ChangeValidator" validation failed: version "v1alpha1", field "^.spec.field":
      new value added as default when previously no default value existed: &JSON{Raw:*[34
      100 101 102 97 117 108 116 45 115 116 114 105 110 103 45 106 105 116 108 105
      34],}'

       

      message: 'validating upgrade for CRD "nginxolm75124s.cache.example.com" failed:
      CustomResourceDefinition nginxolm75124s.cache.example.com failed upgrade safety
      validation. "ChangeValidator" validation failed: version "v1alpha1", field "^.spec.defaultenum":
      default value has been changed from [34 118 97 108 117 101 49 34] to [34 118
      97 108 117 101 51 34]'

       

      message: 'validating upgrade for CRD "nginxolm75124s.cache.example.com" failed:
      CustomResourceDefinition nginxolm75124s.cache.example.com failed upgrade safety
      validation. "ChangeValidator" validation failed: version "v1alpha1", field "^.spec.defaultint":
      default value has been removed when previously a default value existed: [57]'

              lmohanty@redhat.com Lalatendu Mohanty
              rhn-support-jitli Keenon Lee
              Xia Zhao Xia Zhao
              Alex Dellapenta Alex Dellapenta
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: