-
Bug
-
Resolution: Done-Errata
-
Normal
-
None
-
4.18.0
Description of problem:
The disk and instance types for gcp machines should be validated further. The current implementation provides validation for each individually, but the disk types and instance types should be checked against each other for valid combinations. The attached spreadsheet displays the combinations of valid disk and instance types.
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
- blocks
-
-
- Closed
-
-
-
- Closed
-
- causes
-
-
- Closed
-
- is cloned by
-
-
- Closed
-
-
-
- Closed
-
- is related to
-
CORS-3580 Add GCP N4 Machine Series to tested instances for OCP
-
- Closed
-
-
-
- Closed
-
- links to
-
RHEA-2024:6122
OpenShift Container Platform 4.18.z bug fix update
(2 is related to, 4 links to)
[OCPBUGS-41184] GCP Validate Disk and Instance Type
Tested C2/C2D machine types with the build having the latest updates of PR https://github.com/openshift/installer/pull/9043.
$ openshift-install version openshift-install 4.18.0-0.test-2024-09-25-023130-ci-ln-k7qblp2-latest built from commit 1a0cc54b7dd963f6b9685995a7877b848b7c2ab1 release image registry.build09.ci.openshift.org/ci-ln-k7qblp2/release@sha256:4cd06b4824b385ed3e39d19ce5743a85cc81eef16b912212dd23d5e7bb306cde WARNING Release Image Architecture not detected. Release Image Architecture is unknown release architecture unknown default architecture amd64 $ yq-3.3.0 r test11/install-config.yaml platform gcp: projectID: openshift-qe region: us-central1 $ yq-3.3.0 r test11/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: c2-standard-4 osDisk: diskType: hyperdisk-balanced replicas: 2 $ yq-3.3.0 r test11/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: c2-standard-4 osDisk: diskType: hyperdisk-balanced replicas: 3 $ openshift-install create manifests --dir test11 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "~/.gcp/osServiceAccount.json" ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.gcp.diskType: Invalid value: "hyperdisk-balanced": c2-standard-4 instance requires one of the following disk types: [pd-standard pd-ssd pd-balanced], compute[0].platform.gcp.diskType: Invalid value: "hyperdisk-balanced": c2-standard-4 instance requires one of the following disk types: [pd-standard pd-ssd pd-balanced]] $ $ yq-3.3.0 r test9/install-config.yaml platform gcp: projectID: openshift-qe region: us-central1 $ yq-3.3.0 r test9/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: c2d-standard-2 osDisk: diskType: hyperdisk-balanced replicas: 2 $ yq-3.3.0 r test9/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: c2d-standard-4 osDisk: diskType: hyperdisk-balanced replicas: 3 $ openshift-install create manifests --dir test9 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "~/.gcp/osServiceAccount.json" ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.gcp.diskType: Invalid value: "hyperdisk-balanced": c2d-standard-4 instance requires one of the following disk types: [pd-standard pd-ssd pd-balanced], compute[0].platform.gcp.diskType: Invalid value: "hyperdisk-balanced": c2d-standard-2 instance requires one of the following disk types: [pd-standard pd-ssd pd-balanced]] $ $ yq-3.3.0 r test9/install-config.yaml platform gcp: projectID: openshift-qe region: us-central1 $ yq-3.3.0 r test9/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: c2-standard-2 osDisk: diskType: pd-standard replicas: 2 $ yq-3.3.0 r test9/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: c2-standard-4 osDisk: diskType: pd-balanced replicas: 3 $ openshift-install create manifests --dir test9 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "~/.gcp/osServiceAccount.json" ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: <nil>: Internal error: failed to fetch instance type: googleapi: Error 404: The resource 'projects/openshift-qe/zones/us-central1-c/machineTypes/c2-standard-2' was not found, notFound $ $ sed -i 's/type: c2-standard-2/type: c2-standard-4/' test9/install-config.yaml $ $ openshift-install create manifests --dir test9 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "~/.gcp/osServiceAccount.json" INFO Consuming Install Config from target directory INFO Adding clusters... INFO Manifests created in: test9/cluster-api, test9/manifests and test9/openshift $ $ yq-3.3.0 r test10/install-config.yaml platform gcp: projectID: openshift-qe region: us-central1 $ yq-3.3.0 r test10/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: c2d-standard-4 osDisk: diskType: pd-standard replicas: 2 $ yq-3.3.0 r test10/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: c2d-standard-4 osDisk: diskType: pd-balanced replicas: 3 $ openshift-install create manifests --dir test10 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "~/.gcp/osServiceAccount.json" INFO Consuming Install Config from target directory INFO Adding clusters... INFO Manifests created in: test10/cluster-api, test10/manifests and test10/openshift $
rhn-support-jiwei Good catch on the C2 and C2D instances. I accidentally marked them as unsupported in my spreadsheet. This should be fixed. It looks like pd-ssd, pd-balanced, and pd-standard are the supported disk types for those instance types.
Finished the testing using the build having the PR https://github.com/openshift/installer/pull/9043, see the test results.
rh-ee-bbarbach According to the OCP documentation, the machine series C2 and C2D are supported. Could you please clarify? Thanks!
$ yq-3.3.0 r test1/install-config.yaml platform gcp: projectID: openshift-qe region: us-central1 $ yq-3.3.0 r test1/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: c2-standard-4 osDisk: diskType: pd-standard replicas: 2 $ yq-3.3.0 r test1/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: c2d-standard-8 osDisk: diskType: pd-balanced replicas: 3 $ openshift-install create manifests --dir test1 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "/home/fedora/.gcp/osServiceAccount.json" ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.gcp.type: Not found: "c2d", compute[0].platform.gcp.type: Not found: "c2"] $
Hi rh-ee-bbarbach I'm testing with the PR https://github.com/openshift/installer/pull/9043, one quick question here, thanks in advance!
Q: The error message for control-plane tells the N2 machine type requires disk types of pd-standard and etc., but in fact pd-standard is only supported for workers. Is it possible to further enhance the error message?
$ yq-3.3.0 r test1/install-config.yaml platform
gcp:
projectID: openshift-qe
region: us-central1
$ yq-3.3.0 r test1/install-config.yaml compute
- architecture: amd64
hyperthreading: Enabled
name: worker
platform:
gcp:
type: n1-standard-2
osDisk:
diskType: hyperdisk-balanced
replicas: 2
$ yq-3.3.0 r test1/install-config.yaml controlPlane
architecture: amd64
hyperthreading: Enabled
name: master
platform:
gcp:
type: n2-standard-4
osDisk:
diskType: hyperdisk-balanced
replicas: 3
$ openshift-install create manifests --dir test1
WARNING Release Image Architecture not detected. Release Image Architecture is unknown
INFO Credentials loaded from file "/home/fedora/.gcp/osServiceAccount.json"
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.gcp.diskType: Invalid value: "hyperdisk-balanced": n2-standard-4 instance requires one of the following disk types: [pd-standard pd-ssd pd-balanced], compute[0].platform.gcp.diskType: Invalid value: "hyperdisk-balanced": n1-standard-2 instance requires one of the following disk types: [pd-standard pd-ssd pd-balanced]]
$
The 2nd test scenario: N4 machine type + default disk type
$ yq-3.3.0 r test1/install-config.yaml platform gcp: projectID: openshift-qe region: us-central1 $ yq-3.3.0 r test1/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: n4-standard-2 replicas: 2 $ yq-3.3.0 r test1/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: n4-standard-4 replicas: 3 $ openshift-install create manifests --dir test1 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "/home/fedora/.gcp/osServiceAccount.json" ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.gcp.type: Unsupported value: "n4": supported values: "a2", "a3", "c3", "c3d", "e2", "m1", "n1", "n2", "n2d", "t2a", "t2d", compute[0].platform.gcp.type: Unsupported value: "n4": supported values: "a2", "a3", "c3", "c3d", "e2", "m1", "n1", "n2", "n2d", "t2a", "t2d"] $
rh-ee-bbarbach I'm working on the testing. It looks like the first testing scenario telling mis-leading error message.
The test scenario: N4 machine type + unsupported disk type
[1] the install-config snippet and the "create manifests" error message which tells the machine type is unsupported, rather than the disk type is unsupported
$ openshift-install version openshift-install 4.18.0-0.nightly-multi-2024-09-18-085013 built from commit 53d574ae691bc36efb3b9673f32eec6f22592bc0 release image quay.io/openshift-release-dev/ocp-release-nightly@sha256:a33207a6f6f2e2e2dd7121212fd415012adb6c31a6ddfa1911b385436d7722dd WARNING Release Image Architecture not detected. Release Image Architecture is unknown release architecture unknown default architecture amd64 $ $ yq-3.3.0 r test1/install-config.yaml platform gcp: projectID: openshift-qe region: us-central1 $ yq-3.3.0 r test1/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: n4-standard-2 osDisk: diskType: pd-standard replicas: 2 $ yq-3.3.0 r test1/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: n4-standard-4 osDisk: diskType: pd-balanced replicas: 3 $ $ openshift-install create manifests --dir test1 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "/home/fedora/.gcp/osServiceAccount.json" ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.gcp.type: Unsupported value: "n4": supported values: "a2", "a3", "c3", "c3d", "e2", "m1", "n1", "n2", "n2d", "t2a", "t2d", compute[0].platform.gcp.type: Unsupported value: "n4": supported values: "a2", "e2", "n1", "n2", "n2d", "t2a", "t2d"] $
[2] after correcting the disk types, "create manifests" could succeed
$ sed -i 's/diskType: pd-standard/diskType: hyperdisk-balanced/' test1/install-config.yaml $ sed -i 's/diskType: pd-balanced/diskType: hyperdisk-balanced/' test1/install-config.yaml $ yq-3.3.0 r test1/install-config.yaml compute - architecture: amd64 hyperthreading: Enabled name: worker platform: gcp: type: n4-standard-2 osDisk: diskType: hyperdisk-balanced replicas: 2 $ yq-3.3.0 r test1/install-config.yaml controlPlane architecture: amd64 hyperthreading: Enabled name: master platform: gcp: type: n4-standard-4 osDisk: diskType: hyperdisk-balanced replicas: 3 $ openshift-install create manifests --dir test1 WARNING Release Image Architecture not detected. Release Image Architecture is unknown INFO Credentials loaded from file "/home/fedora/.gcp/osServiceAccount.json" INFO Consuming Install Config from target directory INFO Adding clusters... INFO Manifests created in: test1/cluster-api, test1/manifests and test1/openshift $
OpenShift Jira Bot
added a comment - Hi rh-ee-bbarbach,
Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.
OpenShift Jira Bot
added a comment - Hi rh-ee-bbarbach ,
Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.
Since the problem described in this issue should be resolved in a recent advisory, it has been closed.
For information on the advisory (Important: OpenShift Container Platform 4.18.1 bug fix and security update), and where to find the updated files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHSA-2024:6122