Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-38537

PF4 chart color CSS variables not available in OpenShift 4.15+

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • 4.15.z
    • 4.15
    • Management Console
    • None
    • Moderate
    • Yes
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, dynamic plugins using PatternFly 4 referenced variables that are not available in {product-title} 4.15 and later. This caused contrast issues for {rh-rhacm-first} in dark mode. With this update, older chart styles are now available to support PatternFly 4 charts used by dynamic plugins. (link:https://issues.redhat.com/browse/OCPBUGS-38537[*OCPBUGS-38537*])
      Show
      * Previously, dynamic plugins using PatternFly 4 referenced variables that are not available in {product-title} 4.15 and later. This caused contrast issues for {rh-rhacm-first} in dark mode. With this update, older chart styles are now available to support PatternFly 4 charts used by dynamic plugins. (link: https://issues.redhat.com/browse/OCPBUGS-38537 [* OCPBUGS-38537 *])
    • Bug Fix
    • Done

      This is a clone of issue OCPBUGS-36816. The following is the description of the original issue:
      —
      Description of problem:

      Dynamic plugins using PatternFly 4 could be referring to PF4 variables that do not exist in OpenShift 4.15+. Currently this is causing contrast issues for ACM in dark mode for donut charts.

      Version-Release number of selected component (if applicable):

      4.15

      How reproducible:

      Always

      Steps to Reproduce:

          1. Install ACM on OpenShift 4.15
    2. Switch to dark mode
    3. Observe Home > Overview page

      Actual results:

       Some categories in the donut charts cannot be seen due to low contrast

      Expected results:

       Colors should match those seen in OpenShift 4.14 and earlier

      Additional info:

      Also posted about this on Slack: https://redhat-internal.slack.com/archives/C011BL0FEKZ/p1720467671332249

Variables like --pf-chart-color-gold-300 are no longer provided, although the PF5 equivalent, --pf-v5-chart-color-gold-300, is available. The stylesheet @patternfly/patternfly/patternfly-charts.scss is present, but not the V4 version. Hopefully it is possible to also include these styles since the names now include a version.

              sgoodwin_redhat Steve goodwin
              openshift-crt-jira-prow OpenShift Prow Bot
              Xiyun Zhao Xiyun Zhao
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: